After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751689 - switch: add a style property for the switch height
switch: add a style property for the switch height
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-06-29 22:29 UTC by Cosimo Cecchi
Modified: 2015-06-30 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
switch: add a style property for the switch height (4.37 KB, patch)
2015-06-29 22:29 UTC, Cosimo Cecchi 		accepted-commit_now Details | Review

Description Cosimo Cecchi 2015-06-29 22:29:25 UTC 
See attached patch. This was requested by the Elementary team at the West Coast hackfest.
Comment 1 Cosimo Cecchi 2015-06-29 22:29:28 UTC 
Created attachment 306345 [details] [review]
switch: add a style property for the switch height

Instead of hardcoding an aspect ratio.
This will be replaced by min-height/max-height when we have them.
Comment 2 Emmanuele Bassi (:ebassi) 2015-06-29 22:50:01 UTC 
Review of attachment 306345 [details] [review]:

Considering that we already have a width style property, I think this is fine.
Comment 3 Matthias Clasen 2015-06-30 20:23:57 UTC 
Review of attachment 306345 [details] [review]:

thanks for the patch
Comment 4 Cosimo Cecchi 2015-06-30 20:28:45 UTC 
Pushed this to master.

Attachment 306345 [details] pushed as 9913b02 - switch: add a style property for the switch height