After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751682 - dashdemux: template parsing does not recognize $$$
dashdemux: template parsing does not recognize $$$
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-29 21:14 UTC by Florin Apostol
Modified: 2015-08-16 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (2.16 KB, patch)
2015-06-29 21:22 UTC, Florin Apostol
committed Details | Review

Description Florin Apostol 2015-06-29 21:14:06 UTC
The standard says that segment templates contain identifiers separated by $, in the format $identifier$.
The standard also says that $$ should be interpreted as $.

The implementation fails to recognize a $$ after a $ that ends an identifier, eg $Time$$$
Comment 1 Florin Apostol 2015-06-29 21:22:40 UTC
Created attachment 306334 [details] [review]
proposed patch

Also corrects templates starting with $$
Comment 2 Thiago Sousa Santos 2015-06-29 22:35:21 UTC
Review of attachment 306334 [details] [review]:

commit e2d112639145b8a1e2a9611667d106b13d270f7e
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Mon Jun 29 22:18:38 2015 +0100

    dashdemux: corrected recognition of $$$ in segment templates
    
    fixed recognition of $$ after a $ that ends an identifier, eg $Time$$$
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751682