After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751639 - video: Add a "crop" GstMeta transform type
video: Add a "crop" GstMeta transform type
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-29 09:02 UTC by Sebastian Dröge (slomo)
Modified: 2018-11-03 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proof of concept: crop meta transform type (3.25 KB, patch)
2015-08-25 07:49 UTC, Hyunjun Ko
needs-work Details | Review

Description Sebastian Dröge (slomo) 2015-06-29 09:02:43 UTC
See summary, could be useful to have for things like ROI meta.
Comment 1 Nicolas Dufresne (ndufresne) 2015-06-30 01:42:31 UTC
I might be the only one, but I absolutely don't understand what this is about from the information in this report and the summary.
Comment 2 Sebastian Dröge (slomo) 2015-06-30 07:26:22 UTC
Then read the GstMeta docs ;)

GstMetaInfo has a transform_func, which is called to transform the meta on a buffer in various situations. We have those for "copy" and "scale" at least currently. See the implementation for "scale" in the ROI or crop meta for example to get an idea how this stuff works.

Having the same for cropping would probably be a good idea.
Comment 3 Hyunjun Ko 2015-08-25 07:49:38 UTC
Created attachment 309941 [details] [review]
proof of concept: crop meta transform type

I'm not sure if it's correct, but I suggested this as a proof of concept.
I referred to the videocrop element.

Additionally, I'm wondering whether dimension is required.
Comment 4 Nicolas Dufresne (ndufresne) 2017-12-19 01:04:02 UTC
Review of attachment 309941 [details] [review]:

To be useful, we need an implementation for all registered video meta. Also to prove it can works. ROI should be trivial, I think GstVideoOverlayCompositionMeta is the most important here. As videocrop now handle cropping on top of an existing crop, it would be nice proof of concept to also port that element.

::: gst-libs/gst/video/gstvideometa.c
@@ +488,3 @@
 
+/**
+ * gst_video_meta_transform_scale_get_quark:

transform_crop_get_quark

@@ +490,3 @@
+ * gst_video_meta_transform_scale_get_quark:
+ *
+ * Get the #GQuark for the "gst-video-scale" metadata transform operation.

Typo "gst-video-crop"
Comment 5 GStreamer system administrator 2018-11-03 11:39:04 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/203.