After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751436 - Some context menu items have wrong sensitivity
Some context menu items have wrong sensitivity
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-24 12:44 UTC by Ondrej Holy
Modified: 2015-06-24 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix context menu items sensitivity (1.81 KB, patch)
2015-06-24 12:45 UTC, Ondrej Holy 		none Details | Review
Fix "Zoom out" item sensitivity for treemap chart (1.05 KB, patch)
2015-06-24 12:55 UTC, Ondrej Holy 		none Details | Review

Description Ondrej Holy 2015-06-24 12:44:46 UTC 
When Baobab displays a graph of analyzed tree, there is a possibility to right-click the graph area and invoke context menu. Items "Go to parent folder", "Zoom in", "Zoom out" stay always active, even if they can not bring effect (e. g. already in the top directory, maximal zoom).
Comment 1 Ondrej Holy 2015-06-24 12:45:44 UTC 
Created attachment 305998 [details] [review]
Fix context menu items sensitivity

This patch set sensitivity of the mentioned menu items accordingly.
Comment 2 Ondrej Holy 2015-06-24 12:55:58 UTC 
Created attachment 305999 [details] [review]
Fix "Zoom out" item sensitivity for treemap chart

can_zoom_out() returns TRUE if more visible children items are available regardless of MAX_DEPTH. This patch change can_zoom_out()  behavior to return FALSE if MAX_DEPTH is reached.
Comment 3 Stefano Facchini 2015-06-24 13:34:14 UTC 
Thanks, pushed!


Attachment 305998 [details] pushed as 8e696ac - Fix context menu items sensitivity
Attachment 305999 [details] pushed as f192f06 - Fix "Zoom out" item sensitivity for treemap chart