After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751434 - decoder: add initial infrastructure for marking corrupted output
decoder: add initial infrastructure for marking corrupted output
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 750547
 
 
Reported: 2015-06-24 11:52 UTC by Gwenole Beauchesne
Modified: 2015-07-20 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
decoder: add initial infrastructure for marking corrupted output (6.19 KB, patch)
2015-06-24 15:06 UTC, Gwenole Beauchesne
none Details | Review
decoder: h264: track corrupted frames (2.28 KB, patch)
2015-06-24 15:07 UTC, Gwenole Beauchesne
none Details | Review

Description Gwenole Beauchesne 2015-06-24 11:52:42 UTC
Add initial infrastructure in core codec library and vaapidecode to mark corrupted frames as such. A corrupted frame is such a frame that was reconstructed from invalid references for instance.
Comment 1 Gwenole Beauchesne 2015-06-24 15:06:29 UTC
Created attachment 306013 [details] [review]
decoder: add initial infrastructure for marking corrupted output
Comment 2 Gwenole Beauchesne 2015-06-24 15:07:12 UTC
Created attachment 306014 [details] [review]
decoder: h264: track corrupted frames
Comment 3 Gwenole Beauchesne 2015-06-24 15:20:08 UTC
Those changes are safe enough for 0.6.0 but I would like to combine them with fixes for bug #750754. So, probably be postponed for 0.6.1, as I did not actually see a practical user of GST_BUFFER_FLAG_CORRUPTED anyway. :)
Comment 4 Olivier Crête 2015-06-25 03:51:32 UTC
the practical use is to just drop all corrupted frames
Comment 5 sreerenj 2015-06-25 05:00:40 UTC
(In reply to Gwenole Beauchesne from comment #3)
> Those changes are safe enough for 0.6.0 but I would like to combine them
> with fixes for bug #750754. So, probably be postponed for 0.6.1, as I did
> not actually see a practical user of GST_BUFFER_FLAG_CORRUPTED anyway. :)

Yup, we will start the QA regression testing soon. Lets push all these stuffs only after 0.6 release... Thanks..
Comment 6 Gwenole Beauchesne 2015-07-20 13:30:34 UTC
commit 939bdb08a5f23e46e4507774931874fcc721946b
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Wed Jun 24 13:48:46 2015 +0200

    decoder: add initial infrastructure for marking corrupted output.
    
    Add initial infrastructure in core codec library and vaapidecode to mark
    corrupted frames as such. A corrupted frame is such a frame that was
    reconstructed from invalid references for instance.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751434
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>