After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751400 - documentation for using libsecret in C has bad linebreak
documentation for using libsecret in C has bad linebreak
Status: RESOLVED FIXED
Product: libsecret
Classification: Other
Component: General
unspecified
Other Linux
: Normal minor
: ---
Assigned To: libsecret maintainer(s)
libsecret maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-06-23 17:32 UTC by Daniel Kahn Gillmor
Modified: 2015-06-29 12:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
docs: Don't overcomplicate things with the major version in docs (2.97 KB, patch)
2015-06-29 12:40 UTC, Stef Walter 		none Details | Review

Description Daniel Kahn Gillmor 2015-06-23 17:32:08 UTC 
https://developer.gnome.org/libsecret/0.18/using-c.html suggests:

PKG_CHECK_MODULES(LIBSECRET, [libsecret-1
 >= 1.0])
AC_SUBST(LIBSECRET_CFLAGS)
AC_SUBST(LIBSECRET_LIBS)

This should be three lines, and not four.

the linebreak after libsecret-1 is produced by expansion of &major; in docs/reference/libsecret/libsecret-using.sgml, which apparently introduces a newline into the value.

I'm not enough of a sgml wizard to know where the fix needs to happen to patch it myself, sorry.
Comment 1 Stef Walter 2015-06-29 12:40:15 UTC 
Created attachment 306285 [details] [review]
docs: Don't overcomplicate things with the major version in docs

Just hard code '1' instead of using variable substitution.
Comment 2 Stef Walter 2015-06-29 12:42:28 UTC 
This patch should fix things.

Attachment 306285 [details] pushed as 4c08fe2 - docs: Don't overcomplicate things with the major version in docs