GNOME Bugzilla – Bug 751386
aacparse: cannot set LOAS src caps
Last modified: 2015-09-16 15:03:29 UTC
Created attachment 305922 [details] [review] Patch fixing the issue I'm testing with some AAC file extracted from live TV stream. The file starts with LOAS frames with no configuration ("use previous config" bit set). On first LOAS frame, this leads to have aacparse->sample_rate at 0 and aacparse->channels at 0 too. As the element don't have any src caps set, we try to set src caps with these sample rate and channels leading to pipeline error. The fix proposes to avoid setting src caps till we get a valid configuration from next LOAS frames. This works correctly with the sample attached (AAC file gdppayed) Thx
Created attachment 305923 [details] Sample AAC file gdppayed
Created attachment 311415 [details] [review] aacparse: Skip LOAS AAC until a valid config is seen. It's normal when dropping into the middle of a stream to not always have the config available immediately, so skip LOAS until a valid config is seen without either setting invalid caps or erroring out.
This patch achieves the same effect for me, but is a bit simpler.
Created attachment 311453 [details] [review] aacparse: Skip LOAS AAC until a valid config is seen. It's normal when dropping into the middle of a stream to not always have the config available immediately, so skip LOAS until a valid config is seen without either setting invalid caps or erroring out.
This patch ends up doing all the things the original one did, plus modifying some of the debug output to be more sensible.