GNOME Bugzilla – Bug 751369
Clarify controls for showing banners
Last modified: 2017-01-11 11:35:27 UTC
I have encountered a number of people who haven't understood the switches for "banners" in the notification preferences. There have been two issues here: 1. They haven't known what a banner is - the term hasn't been familiar to them. 2. They haven't understood why, in the application preferences, there is a switch for disabling banners - it hasn't been clear why this is different from disabling notifications for the app (which has its own switch). I've updated the mockups with two changes that are intended to resolve these issues: 1. The term "banners" is replaced with the word "popups". 2. A description has been added to the notifications and banners (now popups) switches, which explains why someone might want to disable banners but leave notifications enabled.
The mockups: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/notifications/notifications-wireframes.png
Created attachment 328782 [details] [review] Banners replaced with popups
Review of attachment 328782 [details] [review]: > banners replaced with popups Can you come up with a better commit subject?
Created attachment 328783 [details] [review] Banners renamed to popups
Review of attachment 328783 [details] [review]: > banners renamed to popups How about: Replace unclear "Banner" term in UI ::: panels/notifications/edit-dialog.ui @@ +193,3 @@ + <property name="xalign">0</property> + <attributes> + <attribute name="font-desc" value="<Enter Value> 8"/> This is certainly wrong. Why the size change anyway? (or the attempt at a size change) @@ +194,3 @@ + <attributes> + <attribute name="font-desc" value="<Enter Value> 8"/> + <attribute name="foreground" value="#bababdbdb6b6"/> Dim label?
Created attachment 328857 [details] [review] Replace unclear "Banner" term in UI
Review of attachment 328857 [details] [review]: Thanks for the patch. ::: panels/notifications/edit-dialog.ui @@ +158,3 @@ <property name="margin_bottom">12</property> <child> + <object class="GtkBox" id="box1"> unimportant tip. If we are not addressing the object elsewhere, it doesn't need to have an id. It could be just <object class="GtkBox">. But you could keep it this way if you want. @@ +188,3 @@ + <property name="hexpand">True</property> + <property name="vexpand">True</property> + <packing> This long line causes the dialog to expand. We should have a word wrapping here to match the mockups. Look at what we do on the Mouse panel for a description of the same kind https://git.gnome.org/browse/gnome-control-center/tree/panels/mouse/gnome-mouse-properties.ui#n99 @@ +196,3 @@ + </style> + <attributes> + </packing> <attribute name="scale" value="0.9"/> We use scale way more on control-center. Try grepping for "font-desc" and "scale\"".
Created attachment 329184 [details] [review] Replace unclear "Banner" term in UI
Created attachment 329185 [details] [review] Replace unclear "Banner" term in UI
Marek, could you please review this patch?
(In reply to Bastien Nocera from comment #10) > Marek, could you please review this patch? Sure, I'll do it today.
Review of attachment 329185 [details] [review]: Thank you for the changes you've made. I'll just ask you for 4 another but simple ones and it can go to master. ::: panels/notifications/edit-dialog.ui @@ +185,3 @@ + <property name="can_focus">False</property> + <property name="max-width-chars">42</property> + <property name="wrap">True</property> The "wrap" property is listed twice. @@ +189,3 @@ + <property name="label" translatable="yes">Notifications will continue to appear in the notification list when popups are disabled.</property> + <property name="wrap">True</property> + <property name="lines">0</property> Lets set this to -1. @@ +195,3 @@ + </style> + <attributes> + <attribute name="scale" value="0.9"/> Value 0.83 is used on several places in gnome-control-center and I would prefer it more compared to 0.9. @@ +252,3 @@ <property name="xalign">0</property> <property name="margin_end">15</property> + <property name="label" translatable="yes" context="notifications" comments="Banners here refers to message tray notifications in the middle of the screen.">Show Message _Content in Popups</property> Lets update also the comment to "Popups here..."
Created attachment 343295 [details] [review] Replace unclear "Banner" term in UI
Comment on attachment 343295 [details] [review] Replace unclear "Banner" term in UI Thank you for the changes. I've pushed the patch to master.