GNOME Bugzilla – Bug 751367
dvbbasebin: optional support of target device in uri
Last modified: 2018-11-03 13:36:30 UTC
Created attachment 305901 [details] [review] dvbbasebin: optional support of target device in uri The attached patch improves dvb uri handler to let user set the target DVB device. This is usefull when several DVB frontend cards are connected on the same device. Target device is given in uri using syntax "dvb://<device>/<channel name>": gst-launch-1.0 playbin uri="dvb:///dev/dvb/adapter0/frontend1/France 2" This was tested on B2120 ST reference board running STiH412 'Monaco' chipset with 2x DVB-T frontend card connected. Tested on GStreamer-1.4.5, but patch attached is rebased on master branch.
Could this patch be reviewed ? Any chance to reach GStreamer-1.6 ?
Sorry this fell through the cracks. Git master is frozen now for new features, and this patch is not exactly a one-liner :) I'd say ping again once 1.6 is out then we can get it in once git master is open for new features again.
Ok thks for answer, I'll ping again later.
Hi Tim-Philipp, Could someone get a look to this patch ? BR, Hugues.
It seems to be intended to accept URI from the DVB source not only dvb://<channel> but also dvb://<dev>/<channel> with the adapter and frontend values. I think It will be good to set those value through the URI (though the adapter could have been set on env variable). This could be the another option to provide adapter/frontend value to the source. This patch could bring some problem to someone else who using dvbbasesrc with the URI consisted of dvb://<channel> and channels.conf. The set_properties_for_channel search the specific properties based on channel_name but it mixed with "/dev/adapter%/frontend%/channel_name". So, how about parsing adapter/frontend value from the URI before set_properties_for_channel if exist, and pass the correct channel_name, then set the adapter/frontend properties to dvbsrc. This makes it more reliable for the other use cases.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/262.