GNOME Bugzilla – Bug 751305
bad: fix some issues found using static analysis tools
Last modified: 2015-06-22 09:56:11 UTC
While running static analysis tool(cppcheck) on bad plugins, found some potential issues which might create problems later. Attaching patches for the same.
Created attachment 305794 [details] [review] fix wrong assigment
Created attachment 305795 [details] [review] trivial cleanup
Created attachment 305796 [details] [review] irtspparse initialize framesize
Created attachment 305797 [details] [review] uvch264_src: add missing break
Created attachment 305798 [details] [review] mpeg1systemencode fix wrong assignment
Comment on attachment 305798 [details] [review] mpeg1systemencode fix wrong assignment This plugin was never even ported to 0.8, I've removed it now.
Comment on attachment 305797 [details] [review] uvch264_src: add missing break commit dd3f3142bca5e8750f17d2fdde4c0a689059f319 Author: Vineeth TM <vineeth.tm@samsung.com> Date: Mon Jun 22 11:03:15 2015 +0900 uvch264_src: add missing break in caps query handler There is a missing break statement in switch, which will result in executing default case as well resulting in wrong behavior https://bugzilla.gnome.org/show_bug.cgi?id=751305
Comment on attachment 305795 [details] [review] trivial cleanup commit 39d657c27476659c5f38acd93e5ff098bd84805a Author: Vineeth TM <vineeth.tm@samsung.com> Date: Mon Jun 22 10:58:00 2015 +0900 tsmux: code style fix trivial patch to add proper ( while checking for if(G_UNLIKELY()) https://bugzilla.gnome.org/show_bug.cgi?id=751305
Comment on attachment 305796 [details] [review] irtspparse initialize framesize This doesn't "hurt" of course, but it's also not needed, it's a false positive. commit 794c647f595dbb0bc9abcc6f40aa885a8079fcd6 Author: Tim-Philipp Müller <tim@centricular.com> Date: Mon Jun 22 10:49:50 2015 +0100 irtspparse: reflow code to avoid uninitialized variable warning This should hopefully allow even the most challenged static code analyzer to figure out that it's all fine. Also makes the flow clearer. https://bugzilla.gnome.org/show_bug.cgi?id=751305