After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751255 - videoaggregator: simplifies and improves sink_get_caps.
videoaggregator: simplifies and improves sink_get_caps.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-20 11:43 UTC by Mathieu Duponchelle
Modified: 2015-06-22 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videoaggregator: simplifies and improves sink_get_caps. (1.86 KB, patch)
2015-06-20 11:43 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2015-06-20 11:43:40 UTC 
The problem here was that after removing the formats and
all the things we could convert, we then intersected these
caps with the template caps.

Hence if a subclass offered permissive sink templates
(eg all the possible formats videoconvert handles), but only
one output format, then at negotiation time getcaps returned
caps with the format restricted to that format, even though
we do handle conversion.
Comment 1 Mathieu Duponchelle 2015-06-20 11:43:48 UTC 
Created attachment 305740 [details] [review]
videoaggregator: simplifies and improves sink_get_caps.
Comment 2 Mathieu Duponchelle 2015-06-22 22:59:44 UTC 
Review of attachment 305740 [details] [review]:

commit 1248b00c80aff2f24ce094a89ec58ce5c172afb8
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Sat Jun 20 13:36:27 2015 +0200

    videoaggregator: simplifies and improves sink_get_caps.
    
    The problem here was that after removing the formats and
    all the things we could convert, we then intersected these
    caps with the template caps.
    
    Hence if a subclass offered permissive sink templates
    (eg all the possible formats videoconvert handles), but only
    one output format, then at negotiation time getcaps returned
    caps with the format restricted to that format, even though
    we do handle conversion.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751255