After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751192 - build failures in latest master
build failures in latest master
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-06-19 02:53 UTC by Colin Walters
Modified: 2015-06-19 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix build (856 bytes, patch)
2015-06-19 10:57 UTC, Víctor Manuel Jáquez Leal 		none Details | Review

Comment 1 Colin Walters 2015-06-19 02:56:08 UTC 
Please feel free to revert:

https://git.gnome.org/browse/gnome-continuous/commit/?id=160f2ee6683c3539c17d505310be9683cb985bcb 

when you believe this is fixed.  See https://wiki.gnome.org/Projects/GnomeContinuous/BuildAdministration for more information.
Comment 2 Patrick Welche 2015-06-19 07:50:35 UTC 
Maybe a "tests/data/Makefile.am" file was accidentally not git added in bug 751138? Mike?
Comment 3 Patrick Welche 2015-06-19 10:08:41 UTC 
Just added a tests/data/Makefile to get us going:

https://git.gnome.org/browse/at-spi2-atk/commit/?id=d55eb22a4d19a5aceebb04fc77e19b65d1f38842
Comment 4 Patrick Welche 2015-06-19 10:47:09 UTC 
Untagged at-spi2-atk in gnome-continous:

https://git.gnome.org/browse/gnome-continuous/commit/manifest.json?id=668447308477daf5175e85e92a3cef602de1279c

We'll see if we get further now...
Comment 5 Patrick Welche 2015-06-19 10:55:29 UTC 
According to the pretty web page at https://build.gnome.org/, build still fails - but how on earth do you see the actual log?
Comment 6 Víctor Manuel Jáquez Leal 2015-06-19 10:57:47 UTC 
Created attachment 305679 [details] [review]
fix build
Comment 7 Patrick Welche 2015-06-19 11:00:50 UTC 
Making use of Colin's link above, ccording to
 
http://build.gnome.org/continuous/buildmaster/builds/2015/06/19/25/build/log-at-
spi2-atk.txt
 
the build looks as though it succeeded => I think this is fixed.

(Victor: I think you _do_ want the test files to end up in the tarball, not just hide the build error.)
Comment 8 Mike Gorse 2015-06-19 15:48:12 UTC 
Sorry--forgot to git add the new Makefile.am. Thanks for the fix, Patrick; what you added is essentially the same as what I had.