After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751182 - identity: allow dropping buffers with specified flags
identity: allow dropping buffers with specified flags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: Josep Torra Valles
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-18 20:54 UTC by Aleix Conchillo Flaqué
Modified: 2015-11-13 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add drop-corrupt-frames (3.96 KB, patch)
2015-06-18 21:00 UTC, Aleix Conchillo Flaqué 		none Details | Review
add drop-buffer-flags (3.78 KB, patch)
2015-06-18 21:24 UTC, Aleix Conchillo Flaqué 		none Details | Review
Adds a new property to drop buffers with the specified flags (3.92 KB, patch)
2015-11-12 18:33 UTC, Josep Torra Valles 		committed Details | Review

Description Aleix Conchillo Flaqué 2015-06-18 20:54:41 UTC 
Just a feature request for the identity element. I want to be able to drop corrupt frames in the identity element. Corrupt frames would be frames flagged as: corrupt, decode only or delta unit.

The pipeline would be something like:

gst-launch rtspsrc location=... ! decodebin ! identity drop-corrupt-frames= true ! glimagesink

Patch comming next.
Comment 1 Aleix Conchillo Flaqué 2015-06-18 21:00:06 UTC 
Created attachment 305626 [details] [review]
add drop-corrupt-frames

This does the trick. May be there's another way to this, but I found it useful.
Comment 2 Aleix Conchillo Flaqué 2015-06-18 21:02:04 UTC 
I'm now thinking that may be it would be more generic to have something like:

identity drop-buffers-flag=flag|flag|flag

Which would be more generic.
Comment 3 Aleix Conchillo Flaqué 2015-06-18 21:24:12 UTC 
Created attachment 305630 [details] [review]
add drop-buffer-flags

This is now more generic. You can now drop buffers with the given flags.
Comment 4 Olivier Crête 2015-06-18 22:57:24 UTC 
I like it, would make it easy to drop non-keyframes.
Comment 5 Aleix Conchillo Flaqué 2015-06-30 18:38:49 UTC 
Could this one make it to 1.6 or too late already?
Comment 6 Aleix Conchillo Flaqué 2015-08-18 18:46:56 UTC 
Sorry for asking again, will this one make it to 1.6?
Comment 7 Josep Torra Valles 2015-11-12 17:54:47 UTC 
I would like to push this change.
Does anyone have any objection ?
Comment 8 Josep Torra Valles 2015-11-12 18:33:02 UTC 
Created attachment 315355 [details] [review]
Adds a new property to drop buffers with the specified flags

Added gtk-doc blurb for the new property and a 'Since: 1.8' marker
Comment 9 Josep Torra Valles 2015-11-13 15:45:39 UTC 
commit 2c238705a13566e1191ccf557d396528c27795fc
Author: Aleix Conchillo Flaqué <aleix@oblong.com>
Date:   Thu Jun 18 13:56:53 2015 -0700

    identity: add drop-buffer-flags property
    
    New property drop-buffer-flags that will discard buffers that have the
    given flags set.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751182