GNOME Bugzilla – Bug 751149
dashdemux: add warning messages
Last modified: 2015-06-18 15:47:18 UTC
Added some warning messages in gst_mpd_client_setup_streaming to help debug situations when the function will return FALSE. Also corrected some spelling and some comments. 2 patches attached.
Created attachment 305544 [details] [review] patch 1/2
Created attachment 305545 [details] [review] patch 2/2
Review of attachment 305545 [details] [review]: Minor change needed. I'll merge both after this update. ::: ext/dash/gstmpdparser.c @@ +3538,3 @@ gst_mpdparser_representation_get_mimetype (adapt_set, representation); if (stream->mimeType == GST_STREAM_UNKNOWN) { + GST_WARNING ("No mime type in the representation, aborting..."); I think it would be better phrased as: "unknown mime type in the representation, aborting..." it is set to UNKNOWN when the mimetype doesn't start with audio, video or application. It doesn't necessarily mean there was no mime type in the node.
Created attachment 305602 [details] [review] updated patch 2/2
commit d268f812eb616666251bc689a1e823ee4ed89e3a Author: Florin Apostol <florin.apostol@oregan.net> Date: Thu Jun 18 16:20:26 2015 +0100 dashdemux: added warnings in gst_mpd_client_setup_streaming function Added some warning messages in gst_mpd_client_setup_streaming to help debug situations when the function will return FALSE. Renamed a wrongly spelled variable. https://bugzilla.gnome.org/show_bug.cgi?id=751149 commit e4d6e96c820b7a73d585cd174aca46b3aef8b885 Author: Florin Apostol <florin.apostol@oregan.net> Date: Thu Jun 18 12:21:43 2015 +0100 dashdemux: corrected comments in gstmpdparser.h Corrected some comments in gstmpdparser.h file. Moved gst_mpd_client_get_adaptation_sets function to be grouped with other functions from AdaptationSet group https://bugzilla.gnome.org/show_bug.cgi?id=751149