After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751072 - applemedia: enable sharing of CMBlockBuffer data
applemedia: enable sharing of CMBlockBuffer data
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 751071
Blocks:
 
 
Reported: 2015-06-16 20:00 UTC by Ilya Konstantinov
Modified: 2015-08-16 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
applemedia: enable sharing of CMBlockBuffer data (1.26 KB, patch)
2015-06-16 20:01 UTC, Ilya Konstantinov 		committed Details | Review

Description Ilya Konstantinov 2015-06-16 20:00:56 UTC 
When Apple's CMBlockBuffer objects are currently wrapped in GstMemory (and consequentially in GstBuffer), we do it with GST_MEMORY_FLAG_NO_SHARE. This has the unfortunate side effect of forcing copies. The attached one-line patch fixes that.
Comment 1 Ilya Konstantinov 2015-06-16 20:01:57 UTC 
Created attachment 305426 [details] [review]
applemedia: enable sharing of CMBlockBuffer data
Comment 2 Sebastian Dröge (slomo) 2015-06-25 08:49:28 UTC 
commit ad8bf99f044eaecc5aaf50e5e1c9ce4a9761c67d
Author: Ilya Konstantinov <ilya.konstantinov@gmail.com>
Date:   Mon Apr 27 15:09:18 2015 +0300

    applemedia: enable sharing of CMBlockBuffer data
    
    Instead of wrapping with GST_MEMORY_FLAG_NO_SHARE, we make the GstMemory
    object retain the underlying CMBlockBuffer.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751072