GNOME Bugzilla – Bug 751048
avfvideosrc: caps should indicate frame rate range
Last modified: 2015-06-22 16:23:27 UTC
AVFoundation reports both minimum and maximum frame rate in its formats. We should indicate the frame rate range in caps, rather than just maximum frame rate (as we currently do).
Created attachment 305403 [details] [review] avfvideosrc: add frame rate range to caps
Comment on attachment 305403 [details] [review] avfvideosrc: add frame rate range to caps Please don't commit yet -- this fixes behavior on iOS (where there are FPS ranges) but breaks OS X (where ranges are (25-25), (30-30) etc.). I'll come up with a better patch.
Created attachment 305522 [details] [review] avfvideosrc: add frame rate range to caps Only use GST_AVF_FPS_RANGE_CAPS_NEW when it's an actual range.
Created attachment 305523 [details] [review] (REFACTOR) avfvideosrc:add frame rate range to caps Slightly refactored version of attachment 305522 [details] [review]: - use gst_caps_copy for the RGBA GLMemory variant If you think it's nicer/clearer, commit this patch instead.
commit 58ce6d50a0eaa218c4fc7b7aaeb32f45e5b0b0da Author: Ilya Konstantinov <ilya.konstantinov@gmail.com> Date: Tue Jun 16 17:18:52 2015 +0300 avfvideosrc: add frame rate range to caps When AVFoundation indicates a supported frame rate range, add it to the caps. This is important for devices such as the iPhone 6, which indicate a single AVFrameRateRange of 2fps - 60fps. https://bugzilla.gnome.org/show_bug.cgi?id=751048