GNOME Bugzilla – Bug 750745
Wacom Devices assumed to have a stylus / Express Key Remote
Last modified: 2017-08-15 19:21:22 UTC
Created attachment 305011 [details] Wacom EKR Control Center Screenshot Hello, I work with Ping and Jason at Wacom. We have a new device, the Express Key Remote (EKR), which currently ships with the Cintiq 27HD, but will be made available as a separate peripheral to be used accompanying different tablets. The EKR is basically the "pad" (buttons) broken out into a separate device. The remote “pairs” with a USB dongle and the dongle passes along the button clicks etc that it receives from devices that it is paired with. Some background on the device: Each EKR has a serial number and up to 5 EKRs can be "paired" with a single USB dongle at a time. Wacom sees the a user possibly having multiple remotes and storing different settings for each serial number. I note this as an aside, our main goal at the moment is to support 1 EKR. The bug: I am testing the kernel patch and libwacom data files for this device now and have found that the control center assumes that a Wacom device has a “GsdWacomDevice stylus” that isn't NULL (rightly so up until this point). This is checked with many assertions and g_return_val_if_fails. Unfortunately this Wacom device doesn't have a stylus. Removing some of these checks and checking for a NULL GsdWacomDevice stylus before calling methods with the “GsdWacomDevice stylus” led to the attached image which shows me that another cosmetic issue is that the "Map to Monitor.." button and "Tracking Mode" choice are presented. Since there will be an interface change, I’d like to get your feedback before I proceed.
Created attachment 316681 [details] [review] gsd - add support for Wacom Remote These two patches add support for the Wacom ExpressKey Remote. They require recent changes to libwacom.
Created attachment 316682 [details] [review] gcc - add support for ExpressKey Remote to Wacom Panel
Review of attachment 316682 [details] [review]: Hi Aaron, thanks very much for working on this, and sorry this went unaddressed so far... Code-wise the patches look quite alright to me (a few minor comments below though). UI-wise, the dialog will look somewhat lonely with just a button, but I'd suggest not to think too hard on this issue at the moment, since redesigns are due in the wacom control panel if we're to introduce wayland tablet support. From your description of the device, I guess it makes sense to have some [<|>] buttons in the fullscreen "map buttons" UI, to switch between the tablet pad buttons, and the EKRs that are paired to it. I'll be running the idea through the design team. A general comment about both patches, would be great to update the libwacom requirement in configure.ac too. ::: panels/wacom/cc-wacom-panel.c @@ +326,3 @@ } + if (gsd_wacom_device_get_has_stylus (tablet->pad)) + continue; I find this condition somewhat confusing... checking whether the pad has an stylus? If I'm misguided and this makes sense, a comment here would still be great.
Comment on attachment 316681 [details] [review] gsd - add support for Wacom Remote Marking as reviewed too. The GsdWacomDevice changes as per both patches look alright to me FWIW.
Created attachment 316907 [details] [review] gsd - add support for Wacom Remote - version 2
Created attachment 316908 [details] [review] gcc - add support for ExpressKey Remote to Wacom Panel - version 2
Carlos, can you please look into this before the 3.24 freeze?
Created attachment 345306 [details] [review] add Wacom panel support for the ExpressKey Remote
I fwiw want to push either this or an OSD(and gnome-shell)-side fix before the freeze.
Just want to say there are user like me waiting for this ;) That may even solve bugs (https://sourceforge.net/p/linuxwacom/mailman/message/35713946/). Thanks for your work !
Missing in Gnome 3.24... Did you miss the freeze ?
I respectfully ask not to miss the 3.26 freeze if you can spend some time on this ;) Thanks again !
Hi Camille, FYI, this was already handled in the new incarnation of the pad OSD in gnome-shell in bug #779986, and is available in >= 3.24. Updating this bug went off my radar though... There, if the EKR is correctly plugged (i.e. through a USB slot in your tablet [1]) and wayland/libinput is in use, the label on top of the OSD turns into a combobox where you can switch between cintiq/EKR pads. The OSD will also switch to showing the other layout if you press any button in the pad that's not being currently shown. This doesn't work on X11/wacomdrv though, because there's no known way to know which tablet the EKR is paired with, and the g-c-c UI doesn't observe standalone pads like the EKR (which is why nothing of this patch was applied to g-c-c). Feel free to open a separate bugs to gnome-shell if this doesn't work for you. Perhaps you're testing on X11, that could be improved to make it at least guess the tablet the EKR is paired with (and most likely right if there is one). [1] This requirement can be bypassed with udev rules hackery, but again just applies to libinput. *** This bug has been marked as a duplicate of bug 779986 ***
Hi Carlos, and many thanks for the update, that's a good news ! For some reasons, this is not working for me, but before opening a separate bug, I want to be sure we understand each other (I'm an illustrator, maybe a geeky one, but I'm not a developer): I usually use an Xorg session because my main painting program is Krita, and Krita doesn't support Wayland yet... so I didn't found you updated that. But my Gnome version is 3.24.3 (under Antergos linux - Arch based), and I can't find any change (and no combobox) in the Wacom part of gnome-control-center (is that the OSD you are talking about ?) even if I use a Wayland session and plug in the EKR with an USB cable... but the tablet is working fine and I can draw with Mypaint-git. Please note that nothing appear with lsusb after pluging in the USB cable of the EKR (I tested several plugs)... and that I have some issue with the EKR itself which may be linked, which we are working at with Aaron : https://sourceforge.net/p/linuxwacom/bugs/342/ For the X11 support, yes, I suppose it's a marginal case to use several tablets at the same time, and making it work for 1 tablet and 1 EKR would be fine waiting for the transition to Wayland... But does the EKR really need to be paired with a tablet ? Can't it be use without a tablet just as some device with more buttons (for gaming for example) ? Finally, other notes that may be linked : Gnome control center is naming my Cintiq 27 as "Undefined" in the screen setup, and my "Art pen" is named a "Grip pen"... That's a lot, if there is an IRC channel where we can discuss that before creating new bugs, please give me how it's named, and I can join and discuss this afternoon...
(In reply to Camille Bissuel from comment #14) > Hi Carlos, and many thanks for the update, that's a good news ! > > For some reasons, this is not working for me, but before opening a separate > bug, I want to be sure we understand each other (I'm an illustrator, maybe a > geeky one, but I'm not a developer): > > I usually use an Xorg session because my main painting program is Krita, and > Krita doesn't support Wayland yet... so I didn't found you updated that. > > But my Gnome version is 3.24.3 (under Antergos linux - Arch based), and I > can't find any change (and no combobox) in the Wacom part of > gnome-control-center (is that the OSD you are talking about ?) even if I use With OSD I mean the UI that lets you map keys/actions to pad buttons that appears when you click "Map buttons..." in the control center UI, check https://bug779986.bugzilla-attachments.gnome.org/attachment.cgi?id=347851 to see what I mean. > a Wayland session and plug in the EKR with an USB cable... but the tablet is > working fine and I can draw with Mypaint-git. Hmm, USB cable? AFAIK the micro-USB slot in the EKR just exists for charging purposes, all device communication happen through the USB wireless dongle, which should be plugged directly to the tablet. > > Please note that nothing appear with lsusb after pluging in the USB cable of > the EKR (I tested several plugs)... and that I have some issue with the EKR > itself which may be linked, which we are working at with Aaron : > https://sourceforge.net/p/linuxwacom/bugs/342/ > > For the X11 support, yes, I suppose it's a marginal case to use several > tablets at the same time, and making it work for 1 tablet and 1 EKR would be > fine waiting for the transition to Wayland... But does the EKR really need > to be paired with a tablet ? Can't it be use without a tablet just as some > device with more buttons (for gaming for example) ? It does need to be paired with a tablet... Even though the EKR may look like a general purpose device, in the Wacom panel and the wayland protocol we must deal with it as a tablet pad, and disembodied tablet pads don't quite fit in neither. If we gained UI/protocol to handle devices that are a collection of buttons/sliders/wheels/knobs, an unpaired EKR might be a good fit there. Till then it's just a pad, and pads have associated stylus. > > Finally, other notes that may be linked : Gnome control center is naming my > Cintiq 27 as "Undefined" in the screen setup, and my "Art pen" is named a > "Grip pen"... Hmm, probably a different issue, please file a separate bug and provide evemu-record recordings of your pen and pad devices. It might end up being libwacom though... > > That's a lot, if there is an IRC channel where we can discuss that before > creating new bugs, please give me how it's named, and I can join and discuss > this afternoon... Feel free to join #control-center on irc.gimp.org and ping me :), my nick is garnacho
(In reply to Carlos Garnacho from comment #15) > With OSD I mean the UI that lets you map keys/actions to pad buttons that > appears when you click "Map buttons..." in the control center UI, check > https://bug779986.bugzilla-attachments.gnome.org/attachment.cgi?id=347851 to > see what I mean. > I'm not actually seeing this EKR UI under Wayland :( Fresh off the press: bug 786338