Bug 750643 – Right-click on link cause a crash

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 750643 - Right-click on link cause a crash


Summary:	Right-click on link cause a crash


Status:	RESOLVED FIXED

Product:	epiphany
Classification:	Core
Component:	General
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Epiphany Maintainers
QA Contact:	Epiphany Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-06-09 14:34 UTC by Yosef Or Boczko
Modified:	2015-06-09 14:49 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
ephy-window: fix a context-menu crasher (810 bytes, patch) 2015-06-09 14:49 UTC, Claudio Saavedra	committed	Details \| Review

Description Yosef Or Boczko 2015-06-09 14:34:12 UTC

From one of the last commits, right click on any link caouse epiphany
to crash.

[New Thread 0x7fffd9d24700 (LWP 23291)]

(WebKitWebProcess:23248): GLib-GObject-WARNING **: The property GtkSettings:gtk-menu-images is deprecated and shouldn't be used anymore. It will be removed in a future version.

Program received signal SIGSEGV, Segmentation fault.
g_utf8_strlen (p=0x14 <error: Cannot access memory at address 0x14>, max=-1) at gutf8.c:232
232	gutf8.c: No such file or directory.
(gdb) bt

+ Trace 235140

#0 g_utf8_strlen
at gutf8.c line 232
#1 ellipsize_string
at ephy-window.c line 1684
#2 populate_context_menu
at ephy-window.c line 1779
#3 webkit_marshal_BOOLEAN__OBJECT_BOXED_OBJECT
from /usr/lib/libwebkit2gtk-4.0.so.37
#4 g_closure_invoke
at gclosure.c line 801
#5 signal_emit_unlocked_R
at gsignal.c line 3581
#6 g_signal_emit_valist
at gsignal.c line 3347
#7 g_signal_emit
at gsignal.c line 3393
#8 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#9 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#10 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#11 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#12 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#13 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#14 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#15 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#16 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#17 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#18 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#19 WTF::GMainLoopSource::voidCallback()
from /usr/lib/libjavascriptcoregtk-4.0.so.18
#20 WTF::GMainLoopSource::voidSourceCallback(WTF::GMainLoopSource*)
from /usr/lib/libjavascriptcoregtk-4.0.so.18
#21 g_main_dispatch
at gmain.c line 3122
#22 g_main_context_dispatch
at gmain.c line 3737
#23 g_main_context_iterate
at gmain.c line 3808
#24 g_main_context_iteration
at gmain.c line 3869
#25 g_application_run
at gapplication.c line 2308
#26 main
at ephy-main.c line 486
#0 g_utf8_strlen
at gutf8.c line 232
#1 ellipsize_string
at ephy-window.c line 1684
#2 populate_context_menu
at ephy-window.c line 1779
#3 webkit_marshal_BOOLEAN__OBJECT_BOXED_OBJECT
from /usr/lib/libwebkit2gtk-4.0.so.37
#4 g_closure_invoke
at gclosure.c line 801
#5 signal_emit_unlocked_R
at gsignal.c line 3581
#6 g_signal_emit_valist
#7 g_signal_emit
at gsignal.c line 3393
#8 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#9 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#10 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#11 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#12 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#13 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#14 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#15 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#16 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#17 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#18 ??
from /usr/lib/libwebkit2gtk-4.0.so.37
#19 WTF::GMainLoopSource::voidCallback()
from /usr/lib/libjavascriptcoregtk-4.0.so.18
#20 WTF::GMainLoopSource::voidSourceCallback(WTF::GMainLoopSource*)
from /usr/lib/libjavascriptcoregtk-4.0.so.18
#21 g_main_dispatch
at gmain.c line 3122
#22 g_main_context_dispatch
at gmain.c line 3737
#23 g_main_context_iterate
at gmain.c line 3808
#24 g_main_context_iteration
at gmain.c line 3869
#25 g_application_run
at gapplication.c line 2308
#26 main
at ephy-main.c line 486

Comment 1 Claudio Saavedra 2015-06-09 14:38:43 UTC

Can you try if this fixes it?

diff --git a/src/ephy-window.c b/src/ephy-window.c
index 093f5d3..bc77c5b 100644
--- a/src/ephy-window.c
+++ b/src/ephy-window.c
@@ -1689,7 +1689,7 @@ populate_context_menu (WebKitWebView *web_view,
        gboolean is_video = FALSE;
        gboolean is_audio = FALSE;
        gboolean can_search_selection = FALSE;
-       const char *selected_text;
+       const char *selected_text = NULL;
 
        is_image = webkit_hit_test_result_context_is_image (hit_test_result);

Comment 2 Yosef Or Boczko 2015-06-09 14:42:48 UTC

Look like this patch fixes the crash.

Comment 3 Claudio Saavedra 2015-06-09 14:49:26 UTC

The following fix has been pushed:
3a7e46f ephy-window: fix a context-menu crasher

Comment 4 Claudio Saavedra 2015-06-09 14:49:32 UTC

Created attachment 304867 [details] [review]
ephy-window: fix a context-menu crasher

Initialize variable.