After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750635 - vtenc: add alignment=au to sink caps
vtenc: add alignment=au to sink caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal minor
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-09 13:24 UTC by Ilya Konstantinov
Modified: 2015-06-10 08:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vtenc: add alignment=au to sink caps (1.11 KB, patch)
2015-06-09 21:19 UTC, Ilya Konstantinov 		committed Details | Review

Description Ilya Konstantinov 2015-06-09 13:24:25 UTC 
VT compression callback gets a CMSampleBuffer per frame, so vtenc_h264 should indicate 'alignment=au' in caps.

This will allow 'vtenc_h264 ! vtdec' to work as expected.
Comment 1 Ilya Konstantinov 2015-06-09 21:19:59 UTC 
Created attachment 304900 [details] [review]
vtenc: add alignment=au to sink caps
Comment 2 Sebastian Dröge (slomo) 2015-06-10 08:21:02 UTC 
commit 5db08a8b89d0b9f2db16b0dff315242ae0b59c1f
Author: Ilya Konstantinov <ilya.konstantinov@gmail.com>
Date:   Wed Jun 10 00:16:27 2015 +0300

    vtenc: add alignment=au to sink caps
    
    VT compression callback gets a CMSampleBuffer per frame, so vtenc_h264
    should set 'alignment=au' in sink caps to indicate this.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750635
Comment 3 Tim-Philipp Müller 2015-06-10 08:39:22 UTC 
Just to be sure, stream-format=avc is always au-aligned, so perhaps something else needs fixing for this too. It's good to put it into the caps of course.
Comment 4 Sebastian Dröge (slomo) 2015-06-10 08:44:14 UTC 
vtdec just has stream-format=avc,alignment=au in the caps. I don't think it should drop the alignment, even if it's strictly speaking redundant