After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750631 - GtkAssistant: Allow to set a page with no padding
GtkAssistant: Allow to set a page with no padding
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-06-09 12:29 UTC by Adrien Plazas
Modified: 2015-06-15 01:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot showing how the padding can be annoying (69.48 KB, image/png)
2015-06-09 12:29 UTC, Adrien Plazas
  Details
Boxes' wizard displaying a notification bar on top of its page. (33.33 KB, image/png)
2015-06-12 06:34 UTC, Adrien Plazas
  Details
assistant: Drop hardcoded padding (1.45 KB, patch)
2015-06-12 10:37 UTC, Matthias Clasen
committed Details | Review

Description Adrien Plazas 2015-06-09 12:29:43 UTC
Created attachment 304853 [details]
Screenshot showing how the padding can be annoying

Being able to remove the padding surrounding a page would be really useful when the page is a big complex widget like GtkFileChooserWidget.
Comment 1 Matthias Clasen 2015-06-11 00:33:42 UTC
I'm sorry to say that I don't think embedding a file chooser like that in the assistant makes a lot of sense. You end up with two sidebars, just to name one issue.
Comment 2 Adrien Plazas 2015-06-12 06:29:49 UTC
The file chooser may not be the best example, I just haven't yet found a better way to display it in an assistant without triggering a dialog out of the assistant (a dialog from a dialog doesn't seem to be great design-wise).

But I'm pretty sure this example is good enough: having a notification bar (or an info bar) in a page. I'll attach an example from Boxes' wizard.
Comment 3 Adrien Plazas 2015-06-12 06:34:27 UTC
Created attachment 305117 [details]
Boxes' wizard displaying a notification bar on top of its page.

Another example of why being able to disable the padding could be nice: I want to port Boxe's wizard to GtkAssistant, but Boxes take advantage of having all the space it want to add a notification bar to its wizard.

It currently can't be done in a nice way with GtkAssistant.
Comment 4 Matthias Clasen 2015-06-12 10:37:03 UTC
Created attachment 305129 [details] [review]
assistant: Drop hardcoded padding

This means the pages themselves will be responsible for setting
suitable padding.
Comment 5 Matthias Clasen 2015-06-12 10:42:18 UTC
Unfortunately, I'm not convinced this is compatible enough - it will visually break quite a few assistants out that that assume the padding.
Comment 6 Matthias Clasen 2015-06-15 01:30:50 UTC
Attachment 305129 [details] pushed as cfd85de - assistant: Drop hardcoded padding