GNOME Bugzilla – Bug 750396
make text selection widgets feel more interactive
Last modified: 2015-06-09 19:51:42 UTC
During the london hackfest we identified the helper widgets for altering text selection on touch (and pointer input too) to be too flat and not very interaction-friendly. Also the current symbolic icons used for the widgets don't align properly. We need specific assets with clear :active and :hover states.
Created attachment 304601 [details] [review] Adwaita: updates style for text selection - use consistent widget style. unfortunately using assets - light/dark variant - new assets for text selestions, using existing slider asset for insertion point
The above patch has a number of issues. The text selection widgets don't have a correct anchor point. Would have to be bottom right for the top end, top left for the bottom end. Also it would have to deal with the flipped state for RTL languages. In addition the widgets are linked (:active state on both at the same time) and :hover state is missing (we want to use it for pointer input).
Created attachment 304603 [details] [review] texthandle: Allow setting individual states, and separately to handles Now each handle gets its individual current state, and we can accumulate more than one state on these.
Created attachment 304604 [details] [review] texthandle: Set prelight state on the pointer-interacted handle This will be useful with the theming changes to come.
With these patches, I don't get handles for extended selection. Instead, I see (lt-gtk3-widget-factory:28317): Gtk-WARNING **: drawing failure for widget `GtkApplicationWindow': invalid matrix (not invertible) The handles are lovely, though
(In reply to Matthias Clasen from comment #5) > With these patches, I don't get handles for extended selection. Instead, I > see > > (lt-gtk3-widget-factory:28317): Gtk-WARNING **: drawing failure for widget > `GtkApplicationWindow': invalid matrix (not invertible) I got this working after deleting gtk/gtk.gresource.xml and running make again.
For some reason things from ./gtk/gtk.gresource.xml got lost, thus the new image resources are missing form the patch. Is this file supposed to be edited by hand or is something else generating it?
https://git.gnome.org/browse/gtk+/tree/gtk/Makefile.am#n1134 , it just doesn't regenerate on changes in the relevant subfolders. It might be worth to add a "gresource" target, so "make gresource" redoes it from scratch.
Ah right, regenerating the xml did the trick.
Pushed by accident, but I guess thats ok - we just need to fix the few remaining issues.
Review of attachment 304601 [details] [review]: .
Review of attachment 304603 [details] [review]: .
Review of attachment 304604 [details] [review]: .
Created attachment 304857 [details] [review] adwaita: style tweaks to touch selections - use dark theme assets for the checkboxes and radios - darken the popover for legibility (white bg/black text is really the most problematic background to have). unfortunatley in terms of SCSS structure this is further digging us into the hole of specificity. It would be much nicer to set the .osd class on the popover and have everything just work. I'm sure we'll end up using OSD styled popovers outside the touch context.
Sure, we can try that - as I said on irc, there is some breakage wrt to buttons being auto-linked that you need to debug if you want that.
Attachment 304857 [details] pushed as ac798dc - adwaita: style tweaks to touch selections