After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750369 - Various GBinding cleanups
Various GBinding cleanups
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-06-04 00:11 UTC by Garrett Regier
Modified: 2015-06-04 00:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
binding: Remove conditional from the default transform function (3.50 KB, patch)
2015-06-04 00:20 UTC, Garrett Regier 		committed Details | Review
binding: Simplify the default transform func (1.29 KB, patch)
2015-06-04 00:20 UTC, Garrett Regier 		committed Details | Review

Description Garrett Regier 2015-06-04 00:11:55 UTC 
Various cleanups noticed while looking at GBinding.
Comment 1 Garrett Regier 2015-06-04 00:20:37 UTC 
Created attachment 304560 [details] [review]
binding: Remove conditional from the default transform function

Avoiding checking for INVERT_BOOLEAN each and instead choose the correct function in constructed().
Comment 2 Garrett Regier 2015-06-04 00:20:56 UTC 
Created attachment 304561 [details] [review]
binding: Simplify the default transform func
Comment 3 Emmanuele Bassi (:ebassi) 2015-06-04 00:37:35 UTC 
Review of attachment 304560 [details] [review]:

Okay.
Comment 4 Emmanuele Bassi (:ebassi) 2015-06-04 00:38:10 UTC 
Review of attachment 304561 [details] [review]:

Okay.
Comment 5 Garrett Regier 2015-06-04 00:49:01 UTC 
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.