GNOME Bugzilla – Bug 750286
Callbacks with (transfer full) return types are not transferring ownership
Last modified: 2016-03-21 00:04:38 UTC
Callbacks that have (transfer full) return types are not transferring ownership, as they are supposed to. GtkListBoxCreateWidgetFunc is an example of such callbacks. This was discovered when using gtk_list_box_bind_model from gjs. See bug 746893 for further details.
Created attachment 304441 [details] [review] gi: function: Support callbacks with (transfer full) return types
Review of attachment 304441 [details] [review]: Looks good to me.
Comment on attachment 304441 [details] [review] gi: function: Support callbacks with (transfer full) return types Pushed to master.
Created attachment 304450 [details] [review] [gobject-introspection] tests: Add regression test for (transfer full) returning callbacks
Created attachment 304451 [details] [review] [gjs] tests: Add regression test for (transfer full) returning callbacks
From #gtk+ on GIMPNet: 14:37 <rishi> Jasper: Are these test-cases OK: https://bugzilla.gnome.org/show_bug.cgi?id=750286 ? 14:38 <Jasper> rishi, yep.
Pushed to master.
(In reply to Debarshi Ray from comment #5) > Created attachment 304451 [details] [review] [review] > [gjs] tests: Add regression test for (transfer full) returning callbacks Pushed missing doc-tool tests to master as commit 254ac953c6b18a0d4e93781cd9c29bf3dcd4953a
Hi Debarshi, this commit now makes the test-suite fail on various architectures. See https://bugzilla.gnome.org/show_bug.cgi?id=757328 Can't say if this is a bug in the test itself of actually a real bug which has been uncovered by the test. In any case, would be great if you can have a look at 757328. Atm this is blocking the gjs in Debian.