After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749972 - network: Prevent a use after free crash when removing virtual devices
network: Prevent a use after free crash when removing virtual devices
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-27 14:55 UTC by Rui Matos
Modified: 2015-05-27 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Prevent a use after free crash when removing virtual devices (2.90 KB, patch)
2015-05-27 14:55 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2015-05-27 14:55:22 UTC 
When a virtual device is removed and the instance gets finalized we're
not disconnecting from the real NMDevice's notify signal and thus end
up crashing when the signal fires afterwards.

Avoid that by using g_signal_connect_object() so that when we're
finalized the disconnection happens automatically.
Comment 1 Rui Matos 2015-05-27 14:55:26 UTC 
Created attachment 304080 [details] [review]
network: Prevent a use after free crash when removing virtual devices
Comment 2 Rui Matos 2015-05-27 14:57:46 UTC 
Reported downstream https://bugzilla.redhat.com/show_bug.cgi?id=1221078
Comment 3 Bastien Nocera 2015-05-27 15:06:38 UTC 
Review of attachment 304080 [details] [review]:

Looks good.
Comment 4 Rui Matos 2015-05-27 15:39:44 UTC 
Pushed to gnome-3-14 and gnome-3-16 as well

Attachment 304080 [details] pushed as c42f7d2 - network: Prevent a use after free crash when removing virtual devices