After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749947 - Background uses "active" color from the theme
Background uses "active" color from the theme
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-27 09:05 UTC by Lars Karlitski
Modified: 2015-06-23 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
yelp-settings: don't use ACTIVE background color (1.11 KB, patch)
2015-05-27 09:05 UTC, Lars Karlitski 		committed Details | Review

Description Lars Karlitski 2015-05-27 09:05:28 UTC 
This makes the background orange on Ubuntu's Ambiance theme.
Comment 1 Lars Karlitski 2015-05-27 09:05:32 UTC 
Created attachment 304056 [details] [review]
yelp-settings: don't use ACTIVE background color

GTK_STATE_FLAG_ACTIVE is meant for depressed buttons or the currently
selected row in a list box.

It did use NORMAL prior to b6ac534.
Comment 2 David King 2015-06-01 12:19:28 UTC 
Review of attachment 304056 [details] [review]:

Looks good to me. Please push to master, gnome-3-16 and gnome-3-14 branches.
Comment 3 David King 2015-06-23 09:28:48 UTC 
Review of attachment 304056 [details] [review]:

Pushed to master, gnome-3-16 and gnome-3-14 as commit ff82a62a8dbf4e49148f3752bb8573746040ce52, commit 5e522a1e03ceb69517d4d2e6499f993e43453822 and commit 602c61d36820d117ef1d5b96458d78b8b7a48e6d. Thanks!