GNOME Bugzilla – Bug 749866
broken dist tarball creates directories in /usr/locale
Last modified: 2015-06-12 20:28:43 UTC
Version: 3.16.2.1 The tarball for 3.16.2.1 [1] has a broken build systemd which results in the package creating directories in /usr/locale [2] due to DATADIRNAME being undefined. Afaics, the problem seems to be a broken m4/intltool.m4, which doesn't properly define DATADIRNAME. Would we great if you can spin a new tarball. I don't know, on which platform the tarball was created and which intltool version was installed. Do you have an idea, how we can avoid that this issue happens again? [1] https://download.gnome.org/sources/adwaita-icon-theme/3.16/adwaita-icon-theme-3.16.2.tar.xz [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786723
it's because DATADIRNAME has been removed from intltool https://bazaar.launchpad.net/~intltool/intltool/trunk/revision/742
(In reply to Sebastien Bacher from comment #1) > it's because DATADIRNAME has been removed from intltool > https://bazaar.launchpad.net/~intltool/intltool/trunk/revision/742 has anyone checked how many packages are broken by that? This intltool change seems to at least break adwaita-icon-theme and gnome-icon-theme
Created attachment 305143 [details] [review] Fix intltool locale directory location Recent intltool versions no longer set DATADIRNAME.
Attachment 305143 [details] pushed as f07e611 - Fix intltool locale directory location
I grepped through some of the git repos I have checked out: avahi/configure.ac:avahilocaledir='${prefix}/${DATADIRNAME}/locale' brasero/configure.ac: AC_DEFINE_UNQUOTED(PACKAGE_LOCALE_DIR, "${ac_default_prefix}/${DATADIRNAME}/locale", [Location of package locale files]) brasero/configure.ac: AC_DEFINE_UNQUOTED(PACKAGE_LOCALE_DIR, "${prefix}/${DATADIRNAME}/locale", [Location of package locale files]) file-roller/configure.ac: AC_DEFINE_UNQUOTED(LOCALEDIR, "${ac_default_prefix}/${DATADIRNAME}/locale", [Locale dir]) file-roller/configure.ac: AC_DEFINE_UNQUOTED(LOCALEDIR, "${prefix}/${DATADIRNAME}/locale", [Locale dir]) gnome-applets/configure.ac:gnomelocaledir='${prefix}/${DATADIRNAME}/locale' libwnck/configure.ac:# AM_GLIB_GNU_GETTEXT above substs $DATADIRNAME libwnck/configure.ac:wncklocaledir='${prefix}/${DATADIRNAME}/locale' That list is by no means complete. I guess, they all should be updated to use autoconf 2.60 and @localedir@ https://www.gnu.org/software/gettext/manual/html_node/src_002fMakefile.html