After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749852 - Encoder: HEVC: Add CBR Encoding mode support
Encoder: HEVC: Add CBR Encoding mode support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: High enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 763856 (view as bug list)
Depends on:
Blocks: 758397
 
 
Reported: 2015-05-25 16:20 UTC by sreerenj
Modified: 2017-06-13 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description sreerenj 2015-05-25 16:20:48 UTC
The HEVC(h265) Encoder is still missing features which are providing by other similar encoders like vaapiencode_h264.

-- Add ConstantBitRate  and VariableBitRate encoding mode
Comment 1 sreerenj 2015-06-16 07:02:20 UTC
Moving to next release, the current va-intel-driver is only supporting CQP mode encoding.
Comment 2 sreerenj 2016-03-18 10:45:57 UTC
Now the driver is supporting CBR mode.
Comment 3 Baby octopus 2016-04-12 10:16:56 UTC
Hi, any plans to support this feature?
Comment 4 sreerenj 2016-04-14 07:47:20 UTC
(In reply to Baby octopus from comment #3)
> Hi, any plans to support this feature?

already in todo list, but got busy with other things...patches welcome :)
Comment 5 sreerenj 2016-04-22 11:35:59 UTC
Here is some code for cbr:
https://cgit.freedesktop.org/~sree/gstreamer-vaapi/log/?h=hevc_cbr

Hopefully I can push this by next week after some testing....
I am not satisfied with the quality, also have to check the requirement of SEI header packing.
Comment 6 sreerenj 2016-04-27 14:33:35 UTC
Commit 018ea8b2fc193f64bcaf8f2a58e67d6a806dfce9
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Wed Apr 27 17:10:26 2016 +0300

    encoder: h265: Enable cu_qp_delta_enabled_flag for CBR
    
    It seems driver requires enablement of cu_qp_delta_enabled_flag
    for modifying QP values to controll the CBR mode bitrate.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749852

commit 7ddc7ea0bcb051685de8478abf6daa317774fb2d
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Wed Apr 27 17:06:09 2016 +0300

    encoder: h265: Add CBR Encoding support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749852
Comment 7 sreerenj 2016-04-27 14:34:14 UTC
There is still driver issues which needs to be fixed which is tracking here:
https://bugs.freedesktop.org/show_bug.cgi?id=95173
Comment 8 sreerenj 2016-06-23 14:57:28 UTC
Only gst-discoverer is showing wrong bitrate values but ffmpeg and manual testing indicating correct bitrate for cbr encoded videos.

https://bugs.freedesktop.org/show_bug.cgi?id=95173#c5
https://bugs.freedesktop.org/show_bug.cgi?id=95173#c7

I have Closed the driver bug and we have a separate bug to track the PACKED_SEI feature enablement(#766047) too.

Since the HEVC CBR mode encoding is functional (even though there are quality issues) in master branch, I am closing this bug.
Comment 9 Víctor Manuel Jáquez Leal 2017-06-13 15:07:33 UTC
*** Bug 763856 has been marked as a duplicate of this bug. ***