After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749815 - curlsink: handle socket callback for active FTP connections as well
curlsink: handle socket callback for active FTP connections as well
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-25 07:46 UTC by Patricia Muscalu
Modified: 2015-05-25 18:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
handle socket callback for FTP connections as well (3.23 KB, patch)
2015-05-25 07:48 UTC, Patricia Muscalu 		none Details | Review
handle socket callback for FTP connections as well (3.57 KB, patch)
2015-05-25 10:38 UTC, Patricia Muscalu 		committed Details | Review

Description Patricia Muscalu 2015-05-25 07:46:29 UTC 
Since version 7.28.0, libcurl allows application to set socket options for active FTP connections.
Some code adjustments have to be done in curlsink in order to handle active connections correctly.
Comment 1 Patricia Muscalu 2015-05-25 07:48:57 UTC 
Created attachment 303901 [details] [review]
handle socket callback for FTP connections as well

Tested this patch against libcurl version 7.37.1.
Comment 2 Tim-Philipp Müller 2015-05-25 10:23:18 UTC 
Comment on attachment 303901 [details] [review]
handle socket callback for FTP connections as well

Could you please attach a patch in git format-patch format?
Comment 3 Patricia Muscalu 2015-05-25 10:38:28 UTC 
Created attachment 303904 [details] [review]
handle socket callback for FTP connections as well

Sorry! Adding the correct patch.
Comment 4 Tim-Philipp Müller 2015-05-25 18:39:16 UTC 
Pushed, thanks!

commit c1bad1be5d7af242e65ba17b1ca33dae182f6139
Author: Patricia Muscalu <patricia@axis.com>
Date:   Mon May 25 12:33:50 2015 +0200

    curlsink: handle socket callback for active FTP connections as well
    
    Since version 7.28.0, libcurl allows application to set
    socket options for active FTP connections.
    
    Bump libcurl requirement to version tested.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749815