After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749740 - tools: gst-play: print keyboard shortcuts help in interactive mode.
tools: gst-play: print keyboard shortcuts help in interactive mode.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 749741 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-05-22 17:08 UTC by Danny Song (sedman)
Modified: 2015-05-25 14:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
format patch (2.00 KB, patch)
2015-05-22 17:08 UTC, Danny Song (sedman) 		committed Details | Review

Description Danny Song (sedman) 2015-05-22 17:08:22 UTC 
Created attachment 303834 [details] [review]
format patch

interactive mode has been recently enabled by default.
It will be much better if key guide is shown when gst-play starts or a key is pressed (here 'k' key)
Otherwise, we (esp. for newcomer) have to look into the source which key has which functionality.

Please review this.
Comment 1 Tim-Philipp Müller 2015-05-22 17:14:37 UTC 
*** Bug 749741 has been marked as a duplicate of this bug. ***
Comment 2 Tim-Philipp Müller 2015-05-22 17:15:43 UTC 
You don't have to look at the source code, there is a man page :)
Comment 3 Danny Song (sedman) 2015-05-22 17:17:38 UTC 
oh I didn't know that! thanks!
Comment 4 Danny Song (sedman) 2015-05-22 17:30:06 UTC 
So will this be "wontfix"?

In my opinion, it will be more convenient if key guide is exposed when gst-play is running.
Comment 5 Nicolas Dufresne (ndufresne) 2015-05-22 17:36:37 UTC 
I think this could be nice to have, as a short reminder.
Comment 6 Tim-Philipp Müller 2015-05-22 17:37:19 UTC 
I have not decided yet. I think always printing the whole list is a bit much, but perhaps a one-line message saying 'Press 'k' to see a list of keyboard shortcuts' would be okay.

And maybe it should be mapped to 'h' for help? Not sure.
Comment 7 Tim-Philipp Müller 2015-05-24 15:14:26 UTC 
Pushed with small changes, thanks for the patch!

commit bd35bf593382a1cf88149e306e751d9975adfb5d
Author: danny song <danny.song.ga@gmail.com>
Date:   Sat May 23 01:50:11 2015 +0900

    tools: gst-play: add keyboard shortcut help
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749740
Comment 8 Danny Song (sedman) 2015-05-25 14:59:42 UTC 
:) thanks for your improvement!