After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749662 - Replace the random piece algorithm
Replace the random piece algorithm
Status: RESOLVED OBSOLETE
Product: quadrapassel
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: quadrapassel-maint
quadrapassel-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-21 06:55 UTC by misterhat144
Modified: 2018-05-22 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A patch to apply the random generator described (3.56 KB, patch)
2015-05-21 22:12 UTC, misterhat144
none Details | Review
Restore block preview for theme (1.67 KB, patch)
2015-05-22 05:20 UTC, misterhat144
none Details | Review

Description misterhat144 2015-05-21 06:55:41 UTC
The official Tetris guideline has a much better system for distributing pieces than what's currently used here. The difficult piece mode should remain as is instead of adding this as a third option.

http://tetris.wikia.com/wiki/Random_Generator

"Random Generator generates a sequence of all seven one-sided tetrominoes (I, J, L, O, S, T, Z) permuted randomly, as if they were drawn from a bag. Then it deals all seven tetrominoes to the piece sequence before generating another bag"
Comment 1 Mario Wenzel 2015-05-21 08:34:15 UTC
(2015-05-21 08:01:43) maweki: 
Currently, you can change the piece-algorithm while a game runs and it changes immediately
(2015-05-21 08:02:01) maweki: 
Your implementation of the algorithm needs to abide by that as well.

(2015-05-21 08:03:30) maweki: 
well, if we had three, we would need a dropdown that says "random", "classic", and "hard" and we'll spend more time explaining those to the user.
(2015-05-21 08:04:08) maweki: 
So I think we might as well replace the random one, as long as it fits with the current model
Comment 2 misterhat144 2015-05-21 22:12:55 UTC
Created attachment 303786 [details] [review]
A patch to apply the random generator described
Comment 3 misterhat144 2015-05-22 05:20:02 UTC
Created attachment 303796 [details] [review]
Restore block preview for theme

Didn't realize I was missing this in the first patch. There was no preview block for theme selecting, so I re-added it.
Comment 4 Bastien Nocera 2017-09-02 12:32:37 UTC
Was about to file the same bug!
Comment 5 GNOME Infrastructure Team 2018-05-22 12:30:37 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/quadrapassel/issues/14.