After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749603 - Add support for libsystemd
Add support for libsystemd
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-19 21:38 UTC by Michael Biebl
Modified: 2015-05-23 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Add support for libsystemd (1.96 KB, patch)
2015-05-19 21:40 UTC, Michael Biebl
committed Details | Review

Description Michael Biebl 2015-05-19 21:38:00 UTC
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779766

In systemd v209, released over a year ago, the various libsystemd-* libraries
(libsystemd-journal.so, libsystemd-login.so, libsystem-daemon.so,
libsystemd-id128.so) were merged into a single libsystemd.so library to reduce
code duplication and avoid cyclic dependencies [1].

The attached patch adds support for libsystemd by first checking for libsystemd.pc with a fallback to libsystemd-login.pc. I also intentionally did not change the configure switch to keep changes minimal.

If you only want to support systemd versions > 209 and rename the the configure switch to --enable-systemd, please let me know and I'll update the patch accordingly.

I also noticed a more general issue (which should probably be dealt with in a separate bug report): If one enables features explicitly, like say
--enable-udisks2, the ./configure script does not stop if the dependencies are missing. Instead it simply disables the feature. In such a case the configure step should fail.


[1] http://lists.freedesktop.org/archives/systemd-devel/2014-February/017146.html
Comment 1 Michael Biebl 2015-05-19 21:40:57 UTC
Created attachment 303626 [details] [review]
[PATCH] Add support for libsystemd
Comment 2 Ross Lagerwall 2015-05-23 20:09:44 UTC
(In reply to Michael Biebl from comment #0)
> I also noticed a more general issue (which should probably be dealt with in
> a separate bug report): If one enables features explicitly, like say
> --enable-udisks2, the ./configure script does not stop if the dependencies
> are missing. Instead it simply disables the feature. In such a case the
> configure step should fail.

See bug 646444.
Comment 3 Ross Lagerwall 2015-05-23 20:11:30 UTC
Review of attachment 303626 [details] [review]:

Looks good.
Comment 4 Ross Lagerwall 2015-05-23 20:12:34 UTC
(In reply to Michael Biebl from comment #0)
> Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779766
> 
> In systemd v209, released over a year ago, the various libsystemd-* libraries
> (libsystemd-journal.so, libsystemd-login.so, libsystem-daemon.so,
> libsystemd-id128.so) were merged into a single libsystemd.so library to
> reduce
> code duplication and avoid cyclic dependencies [1].
> 

Thanks. Probably best to leave in support for systemd < 209 for now given that RHEL/CentOS 7 is on v208.