After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749587 - Fix make distcheck.
Fix make distcheck.
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-19 16:28 UTC by Mathieu Duponchelle
Modified: 2015-07-17 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
distcheck: do not force building the vala bindings (699 bytes, patch)
2015-05-19 16:28 UTC, Mathieu Duponchelle
rejected Details | Review
introspection: Install to the correct places. (2.48 KB, patch)
2015-05-19 16:29 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2015-05-19 16:28:53 UTC
There were two separate issues on my machine.
Comment 1 Mathieu Duponchelle 2015-05-19 16:28:56 UTC
Created attachment 303606 [details] [review]
distcheck: do not force building the vala bindings
Comment 2 Mathieu Duponchelle 2015-05-19 16:29:01 UTC
Created attachment 303607 [details] [review]
introspection: Install to the correct places.

make distcheck was failing on my end, because it sets a prefix
which has to be taken into account, this fixes that issue
as shown in the example in :

/usr/share/gobject-introspection-1.0/Makefile.introspection
Comment 3 Bastien Nocera 2015-07-01 10:04:25 UTC
Review of attachment 303606 [details] [review]:

Doesn't that change the file list ultimately? It shouldn't and it seems to me that it would.
Comment 4 Bastien Nocera 2015-07-01 10:06:54 UTC
Review of attachment 303607 [details] [review]:

Sure. Remove the "." from the commit subject though :)
Comment 5 Bastien Nocera 2015-07-17 13:21:43 UTC
Review of attachment 303606 [details] [review]:

I tested this, and this means that, if the dist was created with vala disabled, then we wouldn't be checking that vala is available in the build.

So:
<snip>
Making all in vala
make[4]: Entering directory '/home/hadess/Projects/jhbuild/grilo-tmp/grilo-0.2.13/_build/sub/bindings/vala'
make[4]: *** No rule to make target 'grilo-0.2-custom.vala', needed by 'grilo-0.2.vapi'.  Stop.
make[4]: Leaving directory '/home/hadess/Projects/jhbuild/grilo-tmp/grilo-0.2.13/_build/sub/bindings/vala'
Makefile:412: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1

$ tar tvJf grilo-0.2.13.tar.xz | grep vala
drwxr-xr-x 1000/1000         0 2015-07-17 15:08 grilo-0.2.13/bindings/vala/
-rw-r--r-- 1000/1000     18354 2015-07-17 15:08 grilo-0.2.13/bindings/vala/Makefile.in
-rw-r--r-- 1000/1000      1394 2015-07-10 16:03 grilo-0.2.13/bindings/vala/Makefile.am

So, yes, it fails to check that the necessary vala files are in the dist.
Comment 6 Bastien Nocera 2015-07-17 13:22:58 UTC
Closing as all the patches that were accepted are now committed.