GNOME Bugzilla – Bug 749534
dashdemux: Some suspicious compiler warnings about checking if the unsigned segment index is smaller than 0
Last modified: 2015-05-25 12:51:19 UTC
These probably cause reverse playback to fail in some way, and should probably be fixed by making the segment index signed. gstmpdparser.c:3731:31: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] if (stream->segment_index < 0) ~~~~~~~~~~~~~~~~~~~~~ ^ ~ gstmpdparser.c:3754:31: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] if (stream->segment_index < 0) { ~~~~~~~~~~~~~~~~~~~~~ ^ ~ gstmpdparser.c:3759:31: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] if (stream->segment_index < 0) ~~~~~~~~~~~~~~~~~~~~~ ^ ~ gstmpdparser.c:3784:33: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] if (stream->segment_index < 0) { ~~~~~~~~~~~~~~~~~~~~~ ^ ~ gstmpdparser.c:3908:52: error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-compare] if (seg_idx < stream->segments->len && seg_idx >= 0) ~~~~~~~ ^ ~ 5 errors generated.
Thanks for reporting I have a local fix that I'm testing and should push by the end of the week.
commit 0910540d58f4c7f0c029b3b80e7eaf4a8e2ab4d5 Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Mon May 18 22:33:50 2015 -0300 dashdemux: use signed integet to represent segment index We need to be able to represent -1 to check when we are EOS on reverse playback and unsigned integer won't allow that. CID #1298193 CID #1298194 CID #1298195 https://bugzilla.gnome.org/show_bug.cgi?id=749534