After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749528 - playbin: need to avoid duplicated flag setting
playbin: need to avoid duplicated flag setting
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-18 06:41 UTC by Eunhae Choi
Modified: 2015-05-18 07:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playbin: check flags of playsink before updating (1.13 KB, patch)
2015-05-18 06:48 UTC, Eunhae Choi 		committed Details | Review

Description Eunhae Choi 2015-05-18 06:41:56 UTC 
To avoid the reconfigure playsink with the same flags, playbin needs to check the previous flag of playsink.

Application can set the flags property of playbin with the same value and the pipeline(playsink) can be constructed repeatedly and missed some data at the moment.
Comment 1 Eunhae Choi 2015-05-18 06:48:55 UTC 
Created attachment 303504 [details] [review]
playbin: check flags of playsink before updating

Add duplication checking code about flags of playsink to avoid reconfigure playsink repeatedly.
Comment 2 Sebastian Dröge (slomo) 2015-05-18 07:01:40 UTC 
commit 1b755eb272f4fd3cd9d5d31cc61927520fe033ff
Author: eunhae choi <eunhae1.choi@samsung.com>
Date:   Mon May 18 15:45:01 2015 +0900

    playbin: check the flags before set again
    
    check the previous flags of playsink to avoid the reconfigure of playsink repeatedly
    
    https://bugzilla.gnome.org/show_bug.cgi?id=749528