GNOME Bugzilla – Bug 749436
"When battery power is critical" option isn't an option anymore
Last modified: 2015-06-17 17:00:31 UTC
It's handled in UPower directly now. We should call: GetCriticalAction() on UPower to get the value.
Created attachment 303426 [details] [review] power: Remove critical-battery-action key It's not used anymore.
Created attachment 303427 [details] [review] power: Fix "When battery power is critical" label with UPower 1.0 With UPower 1.0, the critical action to take when the battery level is too low isn't in the hands of the user anymore, but in the hands of the system. It's now handled by UPower directly, through the CriticalPowerAction configuration option. Instead of asking logind whether the system supports hibernation, ask UPower directly what the action will be when we're nearly out of battery.
Review of attachment 303427 [details] [review]: The UI looks weird though since there's nothing the user can do here. I think we either need to make upower have a dbus API to change this or just not show it? ::: panels/power/cc-power-panel.c @@ +1840,3 @@ GVariant *result; GDBusConnection *connection; + const char *label; this needs to be named something else since there's already a GtkWidget *label
Created attachment 303430 [details] [review] power: Fix "When battery power is critical" label with UPower 1.0 With UPower 1.0, the critical action to take when the battery level is too low isn't in the hands of the user anymore, but in the hands of the system. It's now handled by UPower directly, through the CriticalPowerAction configuration option. Instead of asking logind whether the system supports hibernation, ask UPower directly what the action will be when we're nearly out of battery.
(In reply to Rui Matos from comment #3) > Review of attachment 303427 [details] [review] [review]: > > The UI looks weird though since there's nothing the user can do here. > > I think we either need to make upower have a dbus API to change this or just > not show it? This looks the same way it did when hibernation wasn't available. This isn't really something we want users to change in any case. > ::: panels/power/cc-power-panel.c > @@ +1840,3 @@ > GVariant *result; > GDBusConnection *connection; > + const char *label; > > this needs to be named something else since there's already a GtkWidget > *label Yeah, I should have tried to compile the thing, fixed in the latter bug.
(In reply to Bastien Nocera from comment #5) > This looks the same way it did when hibernation wasn't available. This isn't > really something we want users to change in any case. Right, it was like that already. I'm asking if we should change it now since it doesn't look "right" IMO. If we're happy with the non user changeable UI, I think at a minimum we should move the string from the listbox or somehow make it more obvious that this isn't tweakable. Dunno how though, Allan?
(In reply to Rui Matos from comment #6) > If we're happy with the non user changeable UI, I think at a minimum we > should move the string from the listbox or somehow make it more obvious that > this isn't tweakable. Dunno how though, Allan? I'd just remove that row from the listbox altogether.
(In reply to Allan Day from comment #7) > (In reply to Rui Matos from comment #6) > > If we're happy with the non user changeable UI, I think at a minimum we > > should move the string from the listbox or somehow make it more obvious that > > this isn't tweakable. Dunno how though, Allan? > > I'd just remove that row from the listbox altogether. Right. I'll do that for master, but this will have to stay for 3.14 and 3.16.
Comment on attachment 303430 [details] [review] power: Fix "When battery power is critical" label with UPower 1.0 Committed to gnome-3-14 and gnome-3-16 Attachment 303430 [details] pushed as 7b12c68 - power: Fix "When battery power is critical" label with UPower 1.0
Created attachment 303521 [details] [review] power: Remove "When battery power is critical" label With UPower 1.0, the critical action to take when the battery level is too low isn't in the hands of the user anymore, but in the hands of the system. It's now handled by UPower directly, through the CriticalPowerAction configuration option. Instead of asking logind whether the system supports hibernation, remove the action label altogether.
Created attachment 303524 [details] [review] power: Remove "When battery power is critical" label With UPower 1.0, the critical action to take when the battery level is too low isn't in the hands of the user anymore, but in the hands of the system. It's now handled by UPower directly, through the CriticalPowerAction configuration option. Instead of asking logind whether the system supports hibernation, remove the action label altogether.
Comment on attachment 303426 [details] [review] power: Remove critical-battery-action key Removed in master (don't want a newer g-s-d making the old g-c-c crash) Attachment 303426 [details] pushed as d80738c - power: Remove critical-battery-action key
Attachment 303524 [details] pushed as 008d7c1 - power: Remove "When battery power is critical" label
*** Bug 751121 has been marked as a duplicate of this bug. ***