After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749279 - messageTray: Emit signal when notifications are enabled/disabled
messageTray: Emit signal when notifications are enabled/disabled
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-05-12 19:48 UTC by Florian Müllner
Modified: 2015-05-14 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
messageTray: Emit signal when notifications are enabled/disabled (1.05 KB, patch)
2015-05-12 19:48 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2015-05-12 19:48:22 UTC
See patch.
Comment 1 Florian Müllner 2015-05-12 19:48:27 UTC
Created attachment 303282 [details] [review]
messageTray: Emit signal when notifications are enabled/disabled

Since the introduction of per-source notification policy in commit
098bd4509ba0, the NotificationPolicy::enable-changed signal has been
used to track to the 'enable' settings. However as we never actually
emitted that signal, this never worked without a restart - oops.
Comment 2 Rui Matos 2015-05-13 14:53:33 UTC
Review of attachment 303282 [details] [review]:

sure.

commit msg nit: "used to track to the" has too many to's :-)
Comment 3 Florian Müllner 2015-05-14 13:15:33 UTC
Attachment 303282 [details] pushed as 0aa29da - messageTray: Emit signal when notifications are enabled/disabled