GNOME Bugzilla – Bug 749260
disparity: Add a "max-disparity" property
Last modified: 2018-11-03 13:35:24 UTC
Created attachment 303253 [details] [review] add a "max-disparity" property The disparity element based on OpenCV is used for calculating disparities between two input images, but the current element only supports inputs whose maximum disparity is smaller than 16/32/64. (This fixed value depends on the algorithm type) For supporting high-resolution images with larger disparity, I added a new property, "max-disparity". It can control a disparity size the element handles. You can check it using the following command. gst-launch-1.0 multifilesrc location=../L0000000000.png ! pngdec ! videoconvert ! video/x-raw,colorimetry="1:1:0:0" ! disp0.sink_right multifilesrc location=../R0000000000.png ! pngdec ! videoconvert ! video/x-raw,colorimetry="1:1:0:0" ! disp0.sink_left disparity max-disparity=64 name=disp0 method=sbm disp0.src ! videoconvert ! xvimagesink sync=false 2d1ac47a57d7e72c125975353c9e9dac691f50b6
Created attachment 304749 [details] left image from http://www.cvlibs.net/datasets/kitti/
Created attachment 304750 [details] right image from http://www.cvlibs.net/datasets/kitti/
can anybody review this?
Review of attachment 303253 [details] [review]: Please submit a patch with git-format patch format, this patch has no author or commit message information. ::: ext/opencv/gstdisparity.cpp @@ +152,2 @@ #define DEFAULT_METHOD METHOD_SGBM +#define DEFAULT_MAX_DISPARITY 16 What is the drawback for the algorithms that had a default of 32/64 when they receive 16 now? Perhaps having -1 as an 'auto' and keeping the old values for these cases would prevent breaking applications relying on this?
Many disparity candidates significantly decrease algorithm' speed and accuracy. For the best performance, we need to set the proper maximum disparity value, and this value depends on camera resolution, focal length, and position. I modified the patch so that the element uses the original value (16/32/64) when the max-disparity property is -1. Please check it again.
Created attachment 308990 [details] [review] add a "max-disparity" property modified patch so that the element uses the original value when the max-disparity property is -1.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/253.