GNOME Bugzilla – Bug 749188
pan: when "Show Matching Articles' Threads", messages with dangling References not shown
Last modified: 2018-09-21 16:00:56 UTC
Hello A Debian user reported the following problem: ===== When "Show Matching Articles' Threads" is set, sometimes some articles (and their whole threads) are missing from the headers pane. Selecting "Show Matching Articles" (or "Show Matching Articles' subthreads") and then "Show Matching Articles' Threads" again sometimes help. I've been able to reproduce it on specific articles. What was "special" about these articles is that they were in newsgroup A, but had references (in the References header) to articles in another newsgroup B. In pan/data-impl/my-tree.cc (see attached patch for exact place), the assumption is made that, for each article N: thread of N == thread of parent of N This is true only if the parent of N is known! If the parent of N is not in the current newsgroup (or not in the downloaded headers), then "thread of parent of N" is empty, because "parent of N" does not exist. The attached patch fixes this. ==== The patch is https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=show_threads_dangling_reference.patch;att=1;bug=568332 Original Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=568332 I'm going to apply this patch to Debian's version of Pan 0.139 All the best
may be related to https://bugzilla.gnome.org/show_bug.cgi?id=442138
Thanks for your bug report. This has been fixed in: https://git.gnome.org/browse/pan2/commit/?id=af878257ee5dba08a350e2a8f73493b661a4320f Closing.
The proposed patch can also be applied on pan 0.140 around lines 300 of the same file. I can't say if this indicates a potential bug or not.
Possibly. It would be great to confirm with the original reporter who was seeing the bug.
I'm the original reporter. My patch originally applied to function apply_filter, which is now "around lines 300". Commit af878257ee5dba08a350e2a8f73493b661a4320f applies it to function apply_rules. When I wrote my patch, that is against version 0.133, apply_rules did not exist. I'm not aware of what apply_rules does vs what apply_filter does. Can someone explain to me rules vs filter? I mean, my gut feeling is that my patch should be applied to both functions apply_rules and apply_filter, but maybe the explanation will make me change my mind :)
Many thanks for your comment, Lionel. It really looks like the patch should be applied in both places. Would you be able to test Pan from git if I apply the patch?
Hi Heinrich, I believe you wrote that code originally, do you still remember what apply_rules does vs what apply_filter does? Please see the above comments for details. Thanks!
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pan/issues/58.