After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749180 - gnetworkaddress: add return type annotation to parse methods
gnetworkaddress: add return type annotation to parse methods
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-05-10 06:55 UTC by Evan Nemerson
Modified: 2015-05-11 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnetworkaddress: add return type annotation to parse methods (1.24 KB, patch)
2015-05-10 06:55 UTC, Evan Nemerson 		committed Details | Review

Description Evan Nemerson 2015-05-10 06:55:38 UTC 
Created attachment 303170 [details] [review]
gnetworkaddress: add return type annotation to parse methods

g_network_address_parse and parse_uri return GSocketConnectable*, but in reality they are GNetworkAddress instances.
Comment 1 Colin Walters 2015-05-11 15:47:59 UTC 
Review of attachment 303170 [details] [review]:

Worth mentioning that this matches `g_network_address_new()`, so we're being consistent here.

And it looks like danw is the person adding these methods, so he should start doing the type from the start.

/cc danw
Comment 2 Dan Winship 2015-05-11 16:01:18 UTC 
(In reply to Colin Walters from comment #1)
> And it looks like danw is the person adding these methods, so he should
> start doing the type from the start.

Actually, I didn't add either of them, and both of them were written before we were putting annotations in glib itself. So...