GNOME Bugzilla – Bug 748959
mirror repo .filez objects are 0600
Last modified: 2015-08-27 15:37:12 UTC
Saw this while doing something else, in a newly created mirror .filez objects at least are mode 0600 which is a regression.
Created attachment 310050 [details] [review] tests: Build test-lzma with LZMA flags test-lzma builds a copy of the compressor and decompressor directly, so the compiler needs access to the LZMA headers and the linker needs to link the program with liblzma.
Created attachment 310051 [details] [review] pull: Set file mode properly when mirroring The pull mirror mode bypasses decompressing the archive-z2 file objects, instead moving the downloaded temporary object directly into the real object store. Since the temporary objects are created without group or world read permissions, the repo commits will only be readable by the user owning the repo. Change the mode of the temporary objects to 0644 before moving them to the real object store.
Created attachment 310061 [details] [review] 0001-fetcher-Use-0666-umask-for-temporary-files.patch How about this instead?
Yeah, that should work. I thought maybe there was a good reason they were created 0600, but I agree that there's no real reason. Also, thanks for adding the test - I was planning to do that but forgot. Let me do a quick test, but I think that's fine.
Looks good to me.
Did you mean to merge this or are you still testing it?
(In reply to Dan Nicholson from comment #6) > Did you mean to merge this or are you still testing it? Oops, I had meant to before 2015.8. Pushed now, thanks.