GNOME Bugzilla – Bug 748903
fix navigation event leaks
Last modified: 2015-05-05 17:32:46 UTC
.
Created attachment 302873 [details] [review] navigation: fix structure leak if subclass doesn't implement send_event() The send_event() implementation is supposed to consume @structure.
Created attachment 302874 [details] [review] xvimagesink: fix navigation event leak when early returning Create the event *after* the early return check so it's not leaked.
Created attachment 302875 [details] [review] xvimagesink: fix navigation event leak when not handled gst_navigation_message_new_event() is *not* consuming the event so we should always drop our extra reference.
Review of attachment 302874 [details] [review]: ::: sys/xvimage/xvimagesink.c @@ +1147,3 @@ + event = gst_event_new_navigation (structure); + This is correct but I think it would be even better if it was moved further down after the unlock so the contention area has only what should be protected.
Created attachment 302936 [details] [review] xvimagesink: fix navigation event leak when early returning Create the event *after* the early return check so it's not leaked.
commit ca100d117cc5d3c9ed49a28cb1d7696ca50f42f8 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Mon May 4 17:59:30 2015 +0200 xvimagesink: fix navigation event leak when early returning Create the event *after* the early return check so it's not leaked. https://bugzilla.gnome.org/show_bug.cgi?id=748903 commit 9d85e23c3d960724a551e057cf412989174ee875 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Mon May 4 18:00:18 2015 +0200 xvimagesink: fix navigation event leak when not handled gst_navigation_message_new_event() is *not* consuming the event so we should always drop our extra reference. https://bugzilla.gnome.org/show_bug.cgi?id=748903 commit f90bb8140ddbf86e73771946d6c5968b56e0caef Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Mon May 4 17:58:38 2015 +0200 navigation: fix structure leak if subclass doesn't implement send_event() The send_event() implementation is supposed to consume @structure. https://bugzilla.gnome.org/show_bug.cgi?id=748903