After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748875 - opusparse: Generates caps with a rate=0
opusparse: Generates caps with a rate=0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-04 08:41 UTC by Jose Antonio Santos Cadenas
Modified: 2015-05-04 08:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
opusheader: Do not include rate in caps if it is 0 (1.14 KB, patch)
2015-05-04 08:41 UTC, Jose Antonio Santos Cadenas 		committed Details | Review

Description Jose Antonio Santos Cadenas 2015-05-04 08:41:11 UTC 
Created attachment 302842 [details] [review]
opusheader: Do not include rate in caps if it is 0

Running this pipelie produces a not-negotiated error because opusparse sets the rate=0

gst-launch-1.0 audiotestsrc ! opusenc ! rtpopuspay ! rtpopusdepay ! opusparse ! opusdec ! alsasink

Attached is a patch to solve the issue, not setting rate in caps if its value is zero.
Comment 1 Sebastian Dröge (slomo) 2015-05-04 08:51:01 UTC 
commit de827c792dcce91b44c6a8825af60923b9678f7b
Author: Jose Antonio Santos Cadenas <santoscadenas@gmail.com>
Date:   Mon May 4 10:35:55 2015 +0200

    opusheader: Do not include rate in caps if it is 0
    
    As expressed in gst_opus_header_create_caps, value 0 means unset.
    Setting rate value to 0 make negotiation with decoder fail.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748875