After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748820 - oggdemux: remove unnecessary codes
oggdemux: remove unnecessary codes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-03 06:03 UTC by Young Han Lee
Modified: 2015-05-03 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
oggdemux : remove unnecessary codes (1.16 KB, patch)
2015-05-03 06:05 UTC, Young Han Lee 		committed Details | Review

Description Young Han Lee 2015-05-03 06:03:25 UTC 
{code}
/* FIXME: either do something with it or remove it */
list = gst_tag_list_new_empty ();
gst_tag_list_add (list, GST_TAG_MERGE_REPLACE, GST_TAG_SERIAL, serialno,
    NULL);
gst_tag_list_unref (list);
{code}

These lines have done nothing for about 10 years.
Comment 1 Young Han Lee 2015-05-03 06:05:03 UTC 
Created attachment 302787 [details] [review]
oggdemux : remove unnecessary codes

patch
Comment 2 Tim-Philipp Müller 2015-05-03 12:35:22 UTC 
Thanks, pushed:

commit bd40d2e33ff4b112d5ca364ddfaa33efd5cc647b
Author: Young Han Lee <y.lee@lge.com>
Date:   Fri Apr 10 16:05:45 2015 +0900

    oggdemux: remove unused code
    
    These lines have done nothing for about 10 years.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748820