GNOME Bugzilla – Bug 748593
[review] dcbw/wifi-ap-list: use the supplicant's BSS list instead of tracking our own
Last modified: 2015-05-06 20:25:37 UTC
NM has a bunch of logic to track the age of APs in the scan list and remove them when they haven't been seen for a while. This doesn't work well when the machine is in motion, like walking or driving or on a train. Since the supplicant already has all this logic to age APs, let's just use it. We now push some AP aging properties to the supplicant (BSSExpireAge and BSSExpireCount) which will tell the supplicant to remove an AP when it either (a) hasn't been seen for 250 seconds or (b) hasn't been seen in the last two scans, whichever comes first. Then there's a bunch of cleanups in nm-wifi-ap.c to remove unused code.
> wifi: follow supplicant's scan list instead of managing AP lifetime internally - if (priv->scanlist_cull_id) { - g_source_remove (priv->scanlist_cull_id); - priv->scanlist_cull_id = 0; + if (priv->ap_dump_id) { + g_source_remove (priv->ap_dump_id); + priv->ap_dump_id = 0; } Not important, but since yesterday there is a nm_clear_g_source () for this :)
Fixed and repushed with one additional commit to remove an unused platform wifi function.
Seems good to me.
LGTM, pushed two minor fixups
Squashed and merged to master.