GNOME Bugzilla – Bug 748559
vaapipluginbase: Update the pool if there was no pool in the downstream reply
Last modified: 2015-06-17 06:56:08 UTC
Created attachment 302488 [details] [review] vaapipluginbase: Update the pool if there was no pool in the downstream reply Fix regression introduced by bd866479, the query after decide_allocation() always needs a pool in the first slot.
Review of attachment 302488 [details] [review]: I think the real issue is that update_pool is not inititalized. IMHO, the correct fix would be update_pool = pool != NULL; or leave it as is but pre-initialize update_pool to FALSE upper when it is declared.
Created attachment 302550 [details] [review] vaapipluginbase: Update the pool if there was no pool in the downstream reply Fix regression introduced by bd866479, the query after decide_allocation() always needs a pool in the first slot. Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Comment on attachment 302550 [details] [review] vaapipluginbase: Update the pool if there was no pool in the downstream reply commit d70a2e8d130f4bff935d674ce0f8ee8bede6867e Author: Olivier Crete <olivier.crete@collabora.com> Date: Mon Apr 27 19:21:12 2015 -0400 vaapipluginbase: Update the pool if there was no pool in the downstream reply Fix regression introduced by bd866479, the query after decide_allocation() always needs a pool in the first slot. Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com> https://bugzilla.gnome.org/show_bug.cgi?id=748559
This fix here was not correct, I can still make it fail, in case case where there was a NULL entry in the query, we need to "update" it.
Created attachment 305105 [details] [review] vaapipluginbase: Override downstream allocation reply if no pool If the downstream replied without a pool, then override it.
Pushed, thanks for the patch. commit 3241296f67be75a100a7926eee5a7918dd66dc08 Author: Olivier Crete <olivier.crete@collabora.com> Date: Wed Jun 17 09:53:29 2015 +0300 vaapipluginbase: Override downstream allocation reply if no pool If the downstream replied without a pool, then override it. https://bugzilla.gnome.org/show_bug.cgi?id=748559