After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748521 - videodecoder: decide_allocation w/ caps = NULL
videodecoder: decide_allocation w/ caps = NULL
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-27 13:14 UTC by Ilya Konstantinov
Modified: 2018-11-03 11:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ilya Konstantinov 2015-04-27 13:14:51 UTC 
In gst_video_decoder_decide_allocation_default:

  gst_query_parse_allocation (query, &outcaps, NULL);
  gst_video_info_init (&vinfo);
  if (outcaps)
    gst_video_info_from_caps (&vinfo, outcaps);

However, outcaps == NULL is not legit to begin with, and will cause an assertion later in:

  gst_buffer_pool_config_validate_params (config, outcaps, size, min,
            max)

I think the 'if (outcaps)' check can be discarded.

Additionally, we might want to fail fast if !outcaps -- both in gst_video_decoder_decide_allocation_default and gst_base_src_decide_allocation_default.
Comment 1 Ilya Konstantinov 2015-04-27 13:27:31 UTC 
Trying to see how we ended down there:

In gst_video_decoder_negotiate_default:

  if (!state) {
    GST_DEBUG_OBJECT (decoder,
        "Trying to negotiate the pool with out setting the o/p format");
    ret = gst_video_decoder_negotiate_pool (decoder, NULL);
                                                  // ^^^^

In gst_video_decoder_negotiate_pool:

   query = gst_query_new_allocation (caps, TRUE);
                                  // ^^^^ == NULL

That's how we end up sending gst_query_new_allocation with NULL caps.
Comment 2 GStreamer system administrator 2018-11-03 11:37:13 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/184.