After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748512 - [PATCH] libnm: set error when failing registration of old secret agent
[PATCH] libnm: set error when failing registration of old secret agent
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-04-27 09:13 UTC by Lubomir Rintel
Modified: 2015-04-28 10:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libnm: set error when failing registration of old secret agent (936 bytes, text/plain)
2015-04-27 09:13 UTC, Lubomir Rintel
Details

Description Lubomir Rintel 2015-04-27 09:13:49 UTC
Created attachment 302416 [details]
libnm: set error when failing registration of old secret  agent

We return FALSE, we ought to return a meaningful error.
---
 libnm/nm-secret-agent-old.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 1 Dan Williams 2015-04-27 18:40:58 UTC
LGTM
Comment 2 Lubomir Rintel 2015-04-28 10:30:31 UTC
nm-1-0 0d07de4 libnm: set error when failing registration of old secret agent
master 0ea1fb4 libnm: set error when failing registration of old secret agent