GNOME Bugzilla – Bug 748434
Support for the Gentoo distrib
Last modified: 2016-05-27 16:11:26 UTC
Created attachment 302319 [details] [review] Patch for Gentoo support Please find attached a patch to apply to cerbero to add support for the Gentoo distribution to build GStreamer and also to build GStreamer for other platforms such as Android on Gentoo. The package type chosen for Gentoo is a disttarball. Please review and give any feedback if necessary.
Comment on attachment 302319 [details] [review] Patch for Gentoo support Thanks for the patch. Could you elaborate on this change, which doesn't seem directly related to the rest of the patch? >--- a/recipes/build-tools/m4.recipe >+++ b/recipes/build-tools/m4.recipe >@@ -10,4 +10,4 @@ class Recipe(recipe.Recipe): > files_bins = ['m4'] > > def prepare(self): >- self.append_env['CFLAGS'] = " -Wno-error=cast-align " >+ self.append_env['CFLAGS'] = " -Wno-error=cast-align -Wp,-Wunused-macros "
Comment on attachment 302319 [details] [review] Patch for Gentoo support Also the Gentoo support and unrelated changes should be in different patches
What shall we do with this? Are any other changes needed to the patch apart from removing the CFLAGS change? But then seeing that there's been no response from Emmanuel so we might just as well close it.
Tim, Sebastian, (In reply to Tim-Philipp Müller from comment #3) > What shall we do with this? Are any other changes needed to the patch apart > from removing the CFLAGS change? But then seeing that there's been no > response from Emmanuel so we might just as well close it. sorry to not have answered earlier, it is quite busy at the moment. So the diff on the m4.recipe is a modification to allow us to comply with out internal process. It is not necessary to have it to support Gentoo. Best regards, Emmanuel Poitier
Ok, thanks. For Arch we call the version DistroVersion.ARCH_ROLLING, I wonder if GENTOO_ROLLING would make more sense than GENTOO_VERSION here - is that terminology used by Gentoo as well?
Tim, there is no specific scheme Gentoo could impose. I believe it is up to your own naming scheme. Best regards, Emmanuel Poitier
Thanks Emmanuel - but not sure what to make of your answer to be honest :) Are you saying GENTOO_ROLLING would be fine as well, or that it doesn't really make sense?
Ok, let's get this in then: commit 7f59d28c87791062e9dae0cdb6367bc43a19d701 Author: Emmanuel Poitier <emmanuel.poitier@enman.fr> Date: Fri May 27 17:07:10 2016 +0100 Add support for Gentoo distro https://bugzilla.gnome.org/show_bug.cgi?id=748434
Comment on attachment 302319 [details] [review] Patch for Gentoo support Pushed without the m4.recipe changes.