After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748407 - gltransformation: don't initialize multiple shaders on renegotiation
gltransformation: don't initialize multiple shaders on renegotiation
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-24 10:45 UTC by Lubosz Sarnecki
Modified: 2015-04-26 19:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't initialize multiple shaders on renegotiation (1.29 KB, patch)
2015-04-24 10:46 UTC, Lubosz Sarnecki 		committed Details | Review

Description Lubosz Sarnecki 2015-04-24 10:45:44 UTC 
This patch fixes a GstGLShader leak in gltransformation for cases where the pipeline gets renegotiated and gst_gl_base_filter_gl_start is called multiple times.
Comment 1 Lubosz Sarnecki 2015-04-24 10:46:28 UTC 
Created attachment 302284 [details] [review]
don't initialize multiple shaders on renegotiation
Comment 2 Sebastian Dröge (slomo) 2015-04-26 19:23:46 UTC 
commit 51daa8b9e2b351055ce59ed89b0417ff9f7dccb9
Author: Lubosz Sarnecki <lubosz.sarnecki@collabora.co.uk>
Date:   Tue Apr 21 09:43:58 2015 +0200

    gltransformation: don't initialize multiple shaders on renegotiation
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748407
    
    * delete shader if one exists
    * set it to NULL after unrefing