After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748351 - codecanalyzer: prevent corruption due to uninitialized variable
codecanalyzer: prevent corruption due to uninitialized variable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-23 06:52 UTC by Vineeth
Modified: 2015-04-23 11:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
initialize variables before using (3.56 KB, patch)
2015-04-23 06:54 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-04-23 06:52:39 UTC 
xml_files_path and hex_files_path variable are not initialized.
 There are chances that corruption happens when uninitialized variables are freed.
 hence initializing the same to NULL before use.


 and made two trivial fixes to remove unused variables.
Comment 1 Vineeth 2015-04-23 06:54:00 UTC 
Created attachment 302202 [details] [review]
initialize variables before using
Comment 2 Tim-Philipp Müller 2015-04-23 11:34:37 UTC 
Thanks, but in future please submit indentation changes separately from the actual fix:

commit 1f58db52bfb51f979e0e1db78471841e4ee68253
Author: Vineeth T M <vineeth.tm@samsung.com>
Date:   Thu Apr 23 15:53:12 2015 +0900

    codecanalyzer: don't try to free uninitialized pointers
    
    xml_files_path and hex_files_path variable are not initialized.
    There are chances that corruption happens when uninitialized
    variables are freed, so init them to NULL before use.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748351

commit f700eaef8fdb62b77ce4c671d3234b86e5c8e821
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Thu Apr 23 12:23:24 2015 +0100

    codecanalyzer: run gst-indent on code